Skip to content

Improve documentation of review process #329

@acka47

Description

@acka47

After some time without working on SkoHub, both @Phu2 and me were confused about the process, see #327 (comment)

We should add something like this to the documentation, maybe at https://github.com/skohub-io/skohub-vocabs/blob/main/CONTRIBUTING.md#functional-review:

The usual approach:

  1. We merge feature branches into the dev branch.

  2. This triggers a rebuild of test.skohub.io based on the dev branch.

  3. Usually, I am the one to test new features. If needed I adjust/add vocabs in https://github.com/acka47/testing-skohub-vocabs and then trigger a build on test.skohub.io to do the functional review.

  4. If needed, adustments are made in the feature branch and back to 1.).

  5. If I approve the changes, the feature branch is merged into main.

It might make sense to discuss this in the next development meeting.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions