fix: remove props destructure blank line formatting rule

The blanket removal of blank lines after `} = props;` was too aggressive —
it stripped intentional blank lines (e.g. in selector-dynamicPseudoElement).
Remove the formatting rule entirely and regenerate all test outputs to match
recast's actual behavior.

https://claude.ai/code/session_01FfBbr11ihPBfMeuo3r2yX3

Author: claude

src/__tests__/format-output.test.ts

@@ -158,112 +158,6 @@ export function formatOutput(code: string): string {
     return lines.join("\n");
   })();
 
-  // Remove blank line between props destructure and the next statement.
-  // recast inserts a blank line after `const { ... } = props;` inside function bodies.
-  // We use a line-based approach to avoid matching inside string/template literals.
-  out = removeBlankLineAfterPropsDestructure(out);
-
   // Normalize EOF: trim all trailing whitespace, then ensure a single trailing newline.
   return out.trimEnd() + "\n";
 }
-
-/**
- * Remove blank lines after `} = props;` destructuring statements in function bodies.
- * Uses line-by-line analysis to avoid modifying matching patterns inside
- * string/template literals or comments.
- */
-function removeBlankLineAfterPropsDestructure(code: string): string {
-  const lines = code.split("\n");
-  const result: string[] = [];
-  let inString = false;
-  let stringChar = "";
-  let inBlockComment = false;
-  let inTemplateLiteral = false;
-
-  for (let i = 0; i < lines.length; i++) {
-    const line = lines[i] ?? "";
-
-    // Track whether we're inside a multi-line string/comment context.
-    // If so, just pass the line through unchanged.
-    if (inBlockComment) {
-      result.push(line);
-      if (line.includes("*/")) {
-        inBlockComment = false;
-      }
-      continue;
-    }
-    if (inTemplateLiteral) {
-      result.push(line);
-      // Count unescaped backticks to detect end of template literal
-      for (let c = 0; c < line.length; c++) {
-        if (line[c] === "\\") {
-          c++; // skip escaped char
-        } else if (line[c] === "`") {
-          inTemplateLiteral = false;
-        }
-      }
-      continue;
-    }
-    if (inString) {
-      result.push(line);
-      // Multi-line strings (only template literals can truly span lines,
-      // but handle edge cases)
-      if (line.includes(stringChar)) {
-        inString = false;
-      }
-      continue;
-    }
-
-    // Check if this line ends with `} = props;` (the destructuring pattern)
-    // and the next line is blank — if so, skip the blank line.
-    const trimmed = line.trimEnd();
-    if (
-      trimmed.endsWith("} = props;") &&
-      i + 1 < lines.length &&
-      (lines[i + 1] ?? "").trim() === ""
-    ) {
-      result.push(line);
-      i++; // skip the blank line
-      continue;
-    }
-
-    result.push(line);
-
-    // Update string/comment tracking for subsequent lines
-    // Simple heuristic: scan the line for unmatched quotes/comments
-    for (let c = 0; c < line.length; c++) {
-      const ch = line[c];
-      if (ch === "/" && line[c + 1] === "/") {
-        break; // rest of line is a comment
-      }
-      if (ch === "/" && line[c + 1] === "*") {
-        if (!line.includes("*/", c + 2)) {
-          inBlockComment = true;
-        }
-        break;
-      }
-      if (ch === "\\") {
-        c++; // skip escaped char
-        continue;
-      }
-      if (ch === "`") {
-        inTemplateLiteral = true;
-        // Check if it closes on the same line
-        for (let j = c + 1; j < line.length; j++) {
-          if (line[j] === "\\") {
-            j++;
-          } else if (line[j] === "`") {
-            inTemplateLiteral = false;
-            c = j;
-            break;
-          }
-        }
-        if (inTemplateLiteral) {
-          break;
-        }
-      }
-    }
-  }
-
-  return result.join("\n");
-}

src/internal/utilities/format-output.ts

@@ -7,6 +7,7 @@ function Button<C extends React.ElementType = "button">(
   props: Omit<React.ComponentPropsWithRef<C>, "className" | "style"> & { as?: C },
 ) {
   const { as: Component = "button", children, ...rest } = props;
+
   return (
     <Component {...rest} {...stylex.props(styles.button)}>
       {children}
@@ -28,6 +29,7 @@ type StyledTextProps<C extends React.ElementType = typeof Text> = React.Componen
 // When used with as="label", the component's props must be preserved
 function StyledText<C extends React.ElementType = typeof Text>(props: StyledTextProps<C>) {
   const { as: Component = Text, ...rest } = props;
+
   return <Component {...rest} {...stylex.props(styles.text)} />;
 }
 

test-cases/asProp-basic.output.tsx

@@ -28,6 +28,7 @@ function AnimatedText<C extends React.ElementType = "span">(
   props: Omit<React.ComponentPropsWithRef<C>, "className"> & { as?: C },
 ) {
   const { as: Component = "span", children, style, ...rest } = props;
+
   return (
     <Component {...rest} {...mergedSx(styles.animatedText, undefined, style)}>
       {children}

test-cases/asProp-componentRef.output.tsx

@@ -14,6 +14,7 @@ type HeaderTitleProps<C extends React.ElementType = typeof Text> = React.Compone
 
 export function HeaderTitle<C extends React.ElementType = typeof Text>(props: HeaderTitleProps<C>) {
   const { as: Component = Text, ...rest } = props;
+
   return <Component {...rest} {...stylex.props(styles.headerTitle)} />;
 }
 

test-cases/asProp-crossFile.output.tsx

@@ -5,6 +5,7 @@ export function ContentViewContainer<C extends React.ElementType = "div">(
   props: Omit<React.ComponentPropsWithRef<C>, "className" | "style"> & { as?: C },
 ) {
   const { as: Component = "div", children, ...rest } = props;
+
   return (
     <Component {...rest} {...stylex.props(styles.contentViewContainer)}>
       {children}
@@ -37,6 +38,7 @@ export function StyledWrapper<C extends React.ElementType = typeof BaseComponent
   props: StyledWrapperProps<C>,
 ) {
   const { as: Component = BaseComponent, variant, ...rest } = props;
+
   return (
     <Component
       {...rest}

test-cases/asProp-exported.output.tsx

@@ -9,6 +9,7 @@ function Button<C extends React.ElementType = "button">(
   } & { forwardedAs?: React.ElementType },
 ) {
   const { as: Component = "button", forwardedAs, className, children, style, sx, ...rest } = props;
+
   return (
     <Component {...rest} as={forwardedAs} {...mergedSx([styles.button, sx], className, style)}>
       {children}

test-cases/asProp-forwarded.output.tsx

@@ -13,6 +13,7 @@ function FullWidthCopyText<C extends React.ElementType = "div">(
   props: Omit<React.ComponentPropsWithRef<C>, "className" | "style"> & { as?: C },
 ) {
   const { as: Component = "div", children, ...rest } = props;
+
   return (
     <Component {...rest} {...stylex.props(styles.fullWidthCopyText)}>
       {children}

test-cases/asProp-usage.output.tsx

@@ -19,6 +19,7 @@ function Text<C extends React.ElementType = "span">(
     variant = "regular",
     ...rest
   } = props;
+
   return (
     <Component {...rest} {...mergedSx([styles.text, variants[variant], sx], className, style)}>
       {children}
@@ -36,6 +37,7 @@ type LabelProps = {
 // 2. ref with type RefObject<HTMLLabelElement>
 function Label(props: LabelProps) {
   const { children, ref, ...rest } = props;
+
   return (
     <Text ref={ref} {...rest} as="label" {...stylex.props(styles.label)}>
       {children}

test-cases/attrs-asRefType.output.tsx

@@ -23,6 +23,7 @@ type StyledButtonProps = { ref?: React.Ref<HTMLButtonElement> } & React.Componen
 // B's wrapper semantics (as="button") would be lost.
 function StyledButton(props: StyledButtonProps) {
   const { className, style, sx, ...rest } = props;
+
   return <Text {...rest} as="button" {...mergedSx([styles.button, sx], className, style)} />;
 }