Skip to content

Commit 29ad2ca

Browse files
committed
fix column_associations when column names are not strings
1 parent 94c6ef3 commit 29ad2ca

2 files changed

Lines changed: 1 addition & 9 deletions

File tree

skrub/_check_input.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,6 @@ def cast_column_names_to_strings(df):
2020

2121

2222
def _column_names_to_strings(column_names):
23-
non_string = [c for c in column_names if not isinstance(c, str)]
24-
if not non_string:
25-
return column_names
26-
warnings.warn(
27-
f"Some dataframe column names are not strings: {non_string}.\n"
28-
"All dataframe column names must be strings in skrub pipelines; "
29-
"converting to strings."
30-
)
3123
return list(map(str, column_names))
3224

3325

skrub/_column_associations.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ def _stack_symmetric_associations(associations, df):
134134
right_indices[order],
135135
associations[order],
136136
)
137-
col_names = np.asarray(list(map(str, sbd.column_names(df))))
137+
col_names = np.asarray(sbd.column_names(df))
138138
left_column_names, right_column_names = (
139139
col_names[left_indices],
140140
col_names[right_indices],

0 commit comments

Comments
 (0)