Skip to content

Commit 49de27a

Browse files
Update skrub/_session_encoder.py
Co-authored-by: Jérôme Dockès <jerome@dockes.org>
1 parent f0b7684 commit 49de27a

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

skrub/_session_encoder.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,6 @@ def _get_session_column_pandas(
6262
# Assigning a session ID of -1 to rows with nulls in timestamp or group_by columns
6363
# -1 rather than None because adding nulls to a pandas column of integers will
6464
# convert it to float
65-
# This is a problem because session IDs are meant to be grouped over, and
66-
# when the session ID is float32, numerical instability can cause issues
67-
# with grouping if there are a lot of sessions
6865
X_has_nulls = X_has_nulls.assign(**{session_id_column: -1})
6966

7067
X_selected = X_selected.dropna(subset=selected)

0 commit comments

Comments
 (0)