Skip to content

Commit b7c7849

Browse files
committed
_
1 parent f0e13e0 commit b7c7849

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

skrub/_data_ops/_evaluation.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,10 @@ def _check_environment(environment):
435435
# it we use the environment that was passed to evaluate the full
436436
# DataOp. So if we want such a verification it should be a separate
437437
# check done at a higher level (eg in the estimators' `fit`, `predict`
438-
# etc.) where we know we are not working with a sub-DataOp.
438+
# etc.) where we know we are not working with a sub-DataOp. We do perform
439+
# such a check when a key is missing from the env to provide a better
440+
# message, but it is only used for the content of the message rather than
441+
# enforcing no extra keys ahead of time.
439442
#
440443
# - variables ⊂ env: we cannot check that all variables in the DataOp
441444
# have a matching key in the `environment`, because depending on the

0 commit comments

Comments
 (0)