Skip to content

Commit bdeea85

Browse files
authored
Dataop report titles (#1950)
1 parent 7f7b50a commit bdeea85

4 files changed

Lines changed: 30 additions & 9 deletions

File tree

skrub/_data_ops/_inspection.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ def make_url(node):
169169
svg = draw_data_op_graph(data_op, url=make_url).svg.decode("utf-8")
170170
jinja_env = _get_jinja_env()
171171
index = jinja_env.get_template("index.html").render(
172-
{"svg": svg, "node_status": node_status, "title": title}
172+
{"svg": svg, "node_status": node_status, "report_title": title}
173173
)
174174
index_file = output_dir / "index.html"
175175
index_file.write_text(index, "utf-8")
@@ -222,6 +222,7 @@ def make_url(node):
222222
estimator_html_repr = None
223223
node_page = jinja_env.get_template("node.html").render(
224224
dict(
225+
report_title=title,
225226
total_n_nodes=len(g["nodes"]),
226227
node_nb=i,
227228
node_children=node_children,

skrub/_reporting/_data/templates/data_ops/data_ops.css

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@ pre, code {
4242
flex-shrink: 0;
4343
}
4444

45+
.fixed-report-title ~ .data_op-node-wrapper > .data_op-node > nav.main-nav {
46+
padding-top: 30px;
47+
}
48+
4549
.node-details {
4650
flex-grow: 1;
4751
flex-shrink: 1;
@@ -98,12 +102,25 @@ pre, code {
98102
.icon-button {
99103
position: absolute;
100104
left: 5px;
101-
top: 5px;
105+
top: 10px;
102106
padding: 2px;
103107
width: 24px;
104108
height: 24px;
105109
}
106110

111+
.fixed-report-title {
112+
position: absolute;
113+
white-space: nowrap;
114+
overflow: hidden;
115+
text-overflow: ellipsis;
116+
max-width: 90%;
117+
left: 40px;
118+
top: 5px;
119+
padding: 2px;
120+
padding-top: 0;
121+
margin: 0;
122+
}
123+
107124
.error-node polygon {
108125
stroke: red;
109126
stroke-width: 3;

skrub/_reporting/_data/templates/data_ops/index.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44
<head>
55
<meta charset="utf-8">
66
<meta name="viewport" content="width=device-width, initial-scale=1">
7-
<title>run report</title>
7+
<title>{{ report_title if report_title else "DataOp report" }}</title>
88
<style>
99
{% include "data_ops.css" %}
1010
</style>
1111
</head>
1212

1313
<body>
14-
{% if title %}
15-
<h1>{{ title }}</h1>
14+
{% if report_title %}
15+
<h1>{{ report_title }}</h1>
1616
{% endif %}
1717
<p>
1818
Click on a node to display more information.

skrub/_reporting/_data/templates/data_ops/node.html

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<head>
55
<meta charset="utf-8">
66
<meta name="viewport" content="width=device-width, initial-scale=1">
7-
<title>evaluation report</title>
7+
<title>{{ report_title if report_title else "DataOp report" }}</title>
88
<style>
99
{% include "data_ops.css" %}
1010
</style>
@@ -13,6 +13,9 @@
1313
<body>
1414
<button type="button" class="icon-button"
1515
id="toggle-nav">{% include "icons/list.svg" %}</button>
16+
{% if report_title %}
17+
<h2 class="fixed-report-title">{{ report_title }}</h2>
18+
{% endif %}
1619
<div class="data_op-node-wrapper">
1720
<div class="data_op-node">
1821
<nav class="main-nav" data-is-open>
@@ -21,9 +24,6 @@
2124
<div class="node-details" {{ "data-has-error" if error is not none }}
2225
{{ "data-is-skipped" if (error is none) and (report is none) }}>
2326
<h1>{{ node_nb }}: {{ node_repr }}</h1>
24-
{% if node_name %}
25-
<h2><samp>Name: {{ node_name }}</samp></h2>
26-
{% endif %}
2727
<nav class="mini-nav">
2828
<ul>
2929
<li>
@@ -41,6 +41,9 @@ <h2><samp>Name: {{ node_name }}</samp></h2>
4141
</li>
4242
</ul>
4343
</nav>
44+
{% if node_name %}
45+
<h2><samp>Name: {{ node_name }}</samp></h2>
46+
{% endif %}
4447
<div>
4548
{% if node_description %}
4649
<h3>Description:</h3>

0 commit comments

Comments
 (0)