Skip to content

Commit 5b33a29

Browse files
committed
fix deployment button workflow
1 parent c226ec8 commit 5b33a29

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

__tests__/REST.api.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ describe('RESTApi', () => {
396396
.mockResolvedValue({}); // Rest succeed
397397

398398
await expect(RESTApi.createDeployment()).resolves.not.toThrow();
399-
expect(mockAxiosFetch).toHaveBeenCalledTimes(11); // Total number of requests
399+
expect(mockAxiosFetch).toHaveBeenCalledTimes(10); // Total number of requests
400400
});
401401

402402
it('handles network errors during deployment deletion', async () => {
@@ -415,7 +415,7 @@ describe('RESTApi', () => {
415415
.mockResolvedValue({}); // Rest succeed
416416

417417
await expect(RESTApi.deleteDeployment()).resolves.not.toThrow();
418-
expect(mockAxiosFetch).toHaveBeenCalledTimes(11); // Total number of requests
418+
expect(mockAxiosFetch).toHaveBeenCalledTimes(10); // Total number of requests
419419
});
420420
});
421421
});

src/console/pages/components/DeploymentNetworkConsoleButton.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ interface PodResource extends K8sResourceCommon {
4040
};
4141
}
4242

43-
const ROUTE = 'network-observer';
44-
const POD_SELECTOR = { 'app.kubernetes.io/name': 'network-observer' };
43+
const ROUTE = 'skupper-network-observer';
44+
const POD_SELECTOR = { 'app.kubernetes.io/part-of': 'skupper-network-observer' };
4545
const POD_LOADED_STATUS = 'Running';
4646

4747
const DeploymentNetworkConsoleButton = function () {
@@ -51,21 +51,21 @@ const DeploymentNetworkConsoleButton = function () {
5151
const watchResource = {
5252
groupVersionKind,
5353
namespace: NamespaceManager.getNamespace(),
54-
isList: true,
54+
isList: false,
5555
name: ROUTE
5656
};
5757

5858
const watchResourcePod = {
5959
groupVersionKind: groupVersionKindPod,
6060
namespace: NamespaceManager.getNamespace(),
61-
isList: false,
61+
isList: true,
6262
selector: {
6363
matchLabels: POD_SELECTOR
6464
}
6565
};
6666

67-
const [route] = useK8sWatchResource<RouteResource[]>(watchResource);
68-
const [deployment] = useK8sWatchResource<PodResource>(watchResourcePod);
67+
const [route] = useK8sWatchResource<RouteResource>(watchResource);
68+
const [deployments] = useK8sWatchResource<PodResource[]>(watchResourcePod);
6969

7070
const mutationCreate = useMutation({
7171
mutationFn: () => RESTApi.createDeployment()
@@ -86,16 +86,16 @@ const DeploymentNetworkConsoleButton = function () {
8686
mutationDelete.mutate();
8787
};
8888
useEffect(() => {
89-
console.log('route', route);
90-
const data = route?.find((r) => r.metadata?.name?.includes(ROUTE));
89+
const data = route;
9190

9291
if (data?.spec?.host && data?.spec?.port?.targetPort) {
9392
const newUrl = data?.spec?.host ? `${data?.spec?.port?.targetPort}://${data?.spec?.host}` : undefined;
9493
setUrl(newUrl);
9594
}
9695
}, [route]);
9796

98-
const loaded = deployment?.status?.phase === POD_LOADED_STATUS && url;
97+
const deployment = deployments?.[0];
98+
const loaded = deployment?.status?.phase === POD_LOADED_STATUS && !!url;
9999

100100
return (
101101
<Flex justifyContent={{ default: 'justifyContentSpaceBetween' }}>

0 commit comments

Comments
 (0)