fix go vet outputs: unreachable code and explicit attribute assigments

Author: nluaces

cmd/skupper/skupper_kube_site.go

@@ -280,10 +280,13 @@ func (s *SkupperKubeSite) Status(cmd *cobra.Command, args []string) error {
 			routerMode = currentSite.RouterStatus[0].Router.Mode
 
 			statusDataOutput := formatter.StatusData{
-				EnabledIn: formatter.PlatformSupport{"kubernetes", currentSite.Site.Namespace},
-				Mode:      routerMode,
-				SiteName:  currentSite.Site.Name,
-				Policies:  currentSite.Site.Policy,
+				EnabledIn: formatter.PlatformSupport{
+					SupportType: "kubernetes",
+					SupportName: currentSite.Site.Namespace,
+				},
+				Mode:     routerMode,
+				SiteName: currentSite.Site.Name,
+				Policies: currentSite.Site.Policy,
 			}
 
 			err, index := statusManager.GetRouterIndex(currentSite)
@@ -312,7 +315,10 @@ func (s *SkupperKubeSite) Status(cmd *cobra.Command, args []string) error {
 				if siteConfig.Spec.EnableFlowCollector && consoleUrl != "" {
 					statusDataOutput.ConsoleUrl = consoleUrl
 					if siteConfig.Spec.AuthMode == "internal" {
-						statusDataOutput.Credentials = formatter.PlatformSupport{"secret", "'skupper-console-users'"}
+						statusDataOutput.Credentials = formatter.PlatformSupport{
+							SupportType: "secret",
+							SupportName: "'skupper-console-users'",
+						}
 					}
 				}
 			}

cmd/skupper/skupper_kube_token.go

@@ -99,13 +99,11 @@ func (s *SkupperKubeToken) createFromTemplate(cmd *cobra.Command, args []string)
 			fmt.Println()
 			return nil
 		}
-		return nil
 	case "claim":
 		return fmt.Errorf("--template option cannot be used for a claim")
 	default:
 		return fmt.Errorf("invalid token type.")
 	}
-	return nil
 }
 
 func (s *SkupperKubeToken) Status(cmd *cobra.Command, args []string) error {

cmd/skupper/skupper_podman_site.go

@@ -289,7 +289,10 @@ func (s *SkupperPodmanSite) Status(cmd *cobra.Command, args []string) error {
 	}
 
 	statusOutput.Mode = site.GetMode()
-	statusOutput.EnabledIn = formatter.PlatformSupport{"podman", podman.Username}
+	statusOutput.EnabledIn = formatter.PlatformSupport{
+		SupportType: "podman",
+		SupportName: podman.Username,
+	}
 
 	var currentSite = statusManager.GetSiteById(site.Id)
 
@@ -313,7 +316,10 @@ func (s *SkupperPodmanSite) Status(cmd *cobra.Command, args []string) error {
 	if site.EnableFlowCollector {
 		statusOutput.ConsoleUrl = site.GetConsoleUrl()
 		if site.AuthMode == "internal" {
-			statusOutput.Credentials = formatter.PlatformSupport{"podman volume", "'skupper-console-users'"}
+			statusOutput.Credentials = formatter.PlatformSupport{
+				SupportType: "podman volume",
+				SupportName: "'skupper-console-users'",
+			}
 		}
 	}
 

pkg/service_sync/messaging.go

@@ -98,7 +98,6 @@ func (c *sender) _send() error {
 			}
 		}
 	}
-	return nil
 }
 
 type receiver struct {
@@ -160,5 +159,4 @@ func (c *receiver) _receive() error {
 			c.updates <- update
 		}
 	}
-	return nil
 }