Skip to content

Commit 02bcd3d

Browse files
Remove DAI transfers, address nits
1 parent 628bcc3 commit 02bcd3d

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

spell/spell-reviewer-mainnet-checklist.md

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -201,13 +201,6 @@ Repo: https://github.com/sky-ecosystem/spells-mainnet
201201
* [ ] Transfer amount matches Exec Sheet
202202
* [ ] The transfers are tested via `testPayments` test
203203
* [ ] Sum of all SKY transfers tested in `testPayments` matches number in the Exec Sheet
204-
* IF `DAI` surplus buffer transfers are present
205-
* [ ] Recipient address in the instruction is in the checksummed format
206-
* [ ] Recipient address matches Exec Sheet
207-
* [ ] Recipient address variable name matches one found in `addresses_wallets.sol`
208-
* [ ] Transfer amount matches Exec Sheet
209-
* [ ] The transfers are tested via `testPayments` test
210-
* [ ] Sum of all DAI transfers tested in `testPayments` matches number in the Exec Sheet
211204
* IF `USDS` surplus buffer transfers are present
212205
* [ ] Recipient address in the instruction is in the checksummed format
213206
* [ ] Recipient address matches Exec Sheet
@@ -243,10 +236,10 @@ Repo: https://github.com/sky-ecosystem/spells-mainnet
243236
* [ ] Governance facilitators were notified
244237
* [ ] Exec Sheet contains explicit instruction
245238
* [ ] Exec Doc contains explicit instruction
246-
* IF SKY stream ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) is present
239+
* IF new SKY streams ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) are present
247240
* [ ] Vest contract's SKY allowance increased by the cumulative `total` (the sum of all `tot` values)
248241
* [ ] Ensure allowance increase follows archive patterns
249-
* IF SPK stream ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) is present
242+
* IF new SPK streams ([DssVestTransferrable](https://github.com/sky-ecosystem/dss-vest/blob/master/src/DssVest.sol#L463)) are present
250243
* [ ] Vest contract's SPK allowance increased by the cumulative `total` (the sum of all `tot` values)
251244
* [ ] Ensure allowance increase follows archive patterns
252245
* [ ] Tested via:
@@ -309,7 +302,7 @@ Repo: https://github.com/sky-ecosystem/spells-mainnet
309302
* [ ] Ensure `immutable` visibility is only used when fetching addresses from the `ChainLog` via `DssExecLib.getChangelogAddress(key)` and `constant` is used instead for static addresses
310303
* [ ] Fetch addresses as type `address` and wrap with `Like` suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (such as `SKY`)
311304
* [ ] Use the [DssExecLib Core Address Helpers](https://github.com/sky-ecosystem/dss-exec-lib/blob/master/src/DssExecLib.sol#L166) where possible (e.g. `DssExecLib.vat()`)
312-
* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`), EXCEPT where the archive pattern differs from this pattern
305+
* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`)
313306
* Tests
314307
* [ ] Ensure that the `DssExecLib.address` file is not being modified by the spell PR
315308
* [ ] Check all CI tests are passing as at the latest commit
@@ -335,7 +328,7 @@ _Insert your local test logs here_
335328
* [ ] Wait till the Exec Doc is merged
336329
* Exec Doc checks
337330
* [ ] Exec Doc for the specified date is found in the [`sky-ecosystem/executive-votes` GitHub repo](https://github.com/sky-ecosystem/executive-votes)
338-
* [ ] Exec Doc is located in the directory matching the target spell date year (e.g. `2025/`)
331+
* [ ] Exec Doc is located in the directory matching the target spell date year (`YYYY/`)
339332
* [ ] Exec Doc file name follows the format `executive-vote-YYYY-MM-DD-optional-description.md`
340333
* [ ] Extract _permanent_ URL to the raw markdown file and paste it below
341334
_Insert your Raw Exec Doc URL here_

0 commit comments

Comments
 (0)