You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* [ ] Ensure `immutable` visibility is only used when fetching addresses from the `ChainLog` via `DssExecLib.getChangelogAddress(key)` and `constant` is used instead for static addresses
310
303
* [ ] Fetch addresses as type `address` and wrap with `Like` suffix interfaces inline (when making calls), UNLESS archive patterns permit otherwise (such as `SKY`)
311
304
* [ ] Use the [DssExecLib Core Address Helpers](https://github.com/sky-ecosystem/dss-exec-lib/blob/master/src/DssExecLib.sol#L166) where possible (e.g. `DssExecLib.vat()`)
312
-
* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`), EXCEPT where the archive pattern differs from this pattern
305
+
* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`)
313
306
* Tests
314
307
* [ ] Ensure that the `DssExecLib.address` file is not being modified by the spell PR
315
308
* [ ] Check all CI tests are passing as at the latest commit
@@ -335,7 +328,7 @@ _Insert your local test logs here_
335
328
* [ ] Wait till the Exec Doc is merged
336
329
* Exec Doc checks
337
330
* [ ] Exec Doc for the specified date is found in the [`sky-ecosystem/executive-votes` GitHub repo](https://github.com/sky-ecosystem/executive-votes)
338
-
* [ ] Exec Doc is located in the directory matching the target spell date year (e.g. `2025/`)
331
+
* [ ] Exec Doc is located in the directory matching the target spell date year (`YYYY/`)
339
332
* [ ] Exec Doc file name follows the format `executive-vote-YYYY-MM-DD-optional-description.md`
340
333
* [ ] Extract _permanent_ URL to the raw markdown file and paste it below
0 commit comments