You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: spell/star-spell-reviewer-checklist.md
+7-4Lines changed: 7 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -204,7 +204,7 @@ This section outlines the review process and provides concrete action items for
204
204
#### Parameter Changes & Protocol Integration
205
205
-[ ] Star Protocol invariants are maintained after spell execution.
206
206
-[ ] All parameter changes use the appropriate helper functions IF available.
207
-
-[ ] Parameter changes match the Executive Sheet exactly.
207
+
-[ ] Parameter changes match the Executive Sheet or the corresponding Atlas edit exactly.
208
208
-[ ] Spell interacts correctly with existing protocol components.
209
209
-[ ] Proper error handling for all external interactions.
210
210
@@ -226,11 +226,15 @@ EXECUTED_TESTS_LOGS
226
226
227
227
#### Pre-Deployment checks
228
228
-[ ] Actions listed in the [Executive Sheet](https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw/edit) for this Star match the spell scope.
229
+
-[ ] IF Executive Sheet is not yet ready at the time of review, reference [the corresponding Atlas edit weekly proposal](https://forum.sky.money/tag/atlas-edit-weekly-proposal)
229
230
-[ ] Every _Instruction text_ from the Executive Sheet is copied to the spell code as a comment.
231
+
-[ ] IF Executive Sheet is not yet ready at the time of review, reference [the corresponding Atlas edit weekly proposal](https://forum.sky.money/tag/atlas-edit-weekly-proposal)
230
232
-[ ] IF an instruction cannot be taken, it should have an explanation under the instruction prefixed with `// Note:`.
231
233
-[ ] IF an action in the spell doesn't have a relevant instruction, its necessity is explained in a comment prefixed with `// Note:`.
232
234
-[ ] All actions present in the spell code are present in the final Executive Sheet.
235
+
-[ ] IF Executive Sheet is not yet ready at the time of review, reference [the corresponding Atlas edit weekly proposal](https://forum.sky.money/tag/atlas-edit-weekly-proposal)
233
236
-[ ] All actions in the final Executive Sheet are present in the spell code.
237
+
-[ ] IF Executive Sheet is not yet ready at the time of review, reference [the corresponding Atlas edit weekly proposal](https://forum.sky.money/tag/atlas-edit-weekly-proposal)
234
238
-[ ] IF new commits were added after the initial review, the relevant checklist items have been re-verified.
235
239
-[ ] IF no blockers were found, post the completed "Development Stage" checklist stage with the explicit "Good to deploy" note on top.
236
240
@@ -245,8 +249,8 @@ EXECUTED_TESTS_LOGS
245
249
-[ ] Etherscan settings (optimizer, EVM version, license) match local ones.
246
250
-[ ] Every spell is deployed using standard `CREATE` (not `CREATE2`).
247
251
-[ ] Tests are updated to execute against the deployed spell(s).
252
+
-[ ] No test is skipped after deployment
248
253
-[ ] All tests are passing in CI at COMMIT_HASH.
249
-
-[ ] All tests listed above are not `skipped`.
250
254
-[ ] All tests are passing locally at COMMIT_HASH:
251
255
252
256
```
@@ -267,5 +271,4 @@ EXECUTED_TESTS_LOGS
267
271
-[ ] The spell address posted by the crafter in the `#govops` thread matches the spell evaluated above.
268
272
-[ ] Confirm the address (via a separate "reply to" message, restating the address to avoid edits).
269
273
-[ ] Ensure that no changes were made to the code since the spell was deployed and archived.
270
-
-[ ] Approve spell PR for merge via 'Approve' review option.
271
-
-[ ] IF no blockers were found, post the completed "Handover Stage" checklist stage with the explicit pull request approval.
274
+
-[ ] IF no blockers were found, post the completed "Handover Stage" checklist stage with the explicit pull request approval via 'Approve' review option.
0 commit comments