Skip to content

Commit 41c0015

Browse files
committed
fix script name error and other comments adjustments
1 parent 93623ae commit 41c0015

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

spell/spell-crafter-mainnet-workflow.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ Repo: https://github.com/makerdao/spells-mainnet
129129
* [ ] Run `make safeharbor-generate` command in the `spells-mainnet` repo to check for bug bounty updates
130130
* [ ] IF the command outputs hex encoded call:
131131
* [ ] Add the output hex encoded call to the spell using low-level Solidity call.
132-
* [ ] The call MUST use the pattern: `(bool succ, bytes memory err) = AGREEMENT.call(<encodedDATA>);`
132+
* [ ] The call MUST use the pattern: `(bool succ, bytes memory err) = MULTICALL.call(<encodedDATA>);`
133133
* [ ] Ensure proper error handling after the call (e.g., `require(succ, "Bug bounty update failed");`)
134134
* [ ] Add comment above the bug bounty section: `// ----- Bug Bounty Registry Updates -----`
135135
* [ ] Include note: `// Note: Updates to bug bounty registry identified by make generate command`
@@ -149,7 +149,6 @@ Repo: https://github.com/makerdao/spells-mainnet
149149
* [ ] End-to-end "happy path" interaction with the module
150150
* IF bug bounty updates are present
151151
* [ ] Test that all bug bounty registry calls execute successfully
152-
* [ ] Verify `make update-bug-bounty` returns empty diff in test environment after spell execution
153152
* [ ] Tests PASS via `make test`
154153
* [ ] Ensure `DssExecLib` address used in current spell (`DssExecLib.address`) matches `dss-exec-lib` [Latest Release Tag](https://github.com/makerdao/dss-exec-lib/releases/latest)
155154
* [ ] Push committed content to already opened PR
@@ -228,6 +227,7 @@ Repo: https://github.com/makerdao/spells-mainnet
228227
* [ ] Create testnet and cast deployed spell there using `make cast-on-tenderly spell=0x...` command
229228
* [ ] Check that returned `public explorer url` is publicly accessible (e.g. using incognito browser mode)
230229
* [ ] IF `cast-on-tenderly` command is executed several times for the same spell, delete all testnets of the same name except the last one
230+
* [ ] Verify `make safeharbor-generate` returns empty diff in the casted environment after spell execution.
231231
* [ ] Archive Spell via `make archive-spell` for the current date (or `make archive-spell date="YYYY-MM-DD"`) using Target Date inside the Exec Doc
232232
* [ ] Commit & push changes for review
233233
* [ ] Wait for CI to PASS

spell/spell-reviewer-mainnet-checklist.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -273,8 +273,8 @@
273273
* [ ] Target Contract is included in the ChainLog
274274
* [ ] Test Coverage is comprehensive
275275
* IF bug bounty registry updates are present
276-
* [ ] Run `make safeharbor-verify calldata=0xhexEncodedData` command in the `spells-mainnet` repo, passing the calldata in the spell to check for it's validity.
277-
* [ ] Verify the call uses the correct pattern: `(bool succ, bytes memory err) = AGREEMENT.call(<encodedDATA>);`
276+
* [ ] Run `make safeharbor-verify calldata=<encodedDATA>` command passing the calldata in the spell to check for it's validity.
277+
* [ ] Verify the call uses the correct pattern: `(bool succ, bytes memory err) = MULTICALL.call(<encodedDATA>);`
278278
* [ ] Confirm proper error handling is implemented for each call
279279
* [ ] Verify the bug bounty section has appropriate comments/documentation
280280
* IF spell interacts with ChainLog

0 commit comments

Comments
 (0)