Skip to content

Commit 49d9d20

Browse files
feat(spell-crafter-workflow): add additional instructions
1 parent 7f73e56 commit 49d9d20

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

spell/spell-crafter-mainnet-workflow.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ Repo: https://github.com/sky-ecosystem/spells-mainnet
7777
* `// Poll:` IF URL starts with `https://vote.sky.money/polling/`
7878
* `// Forum:` IF URL starts with `https://forum.sky.money/t/`
7979
* `// MIP:` IF URL starts with `https://mips.makerdao.com/mips/details/`
80+
* `// Atlas:` IF URL starts with `https://sky-atlas.powerhouse.io/`
8081
* [ ] IF an action in the spell doesn't have relevant instruction (e.g.: ChainLog version bump), add the explanation below prefixed with `// Note:`
8182
* [ ] IF an instruction can not be directly taken, add a comment below prefixed with `// Note:` (e.g.: `// Note: see dao_resolutions variable declared above`)
8283
* Open draft PR
@@ -123,13 +124,15 @@ Repo: https://github.com/sky-ecosystem/spells-mainnet
123124
* Patch -> Collateral addition or addition/modification (0.0.++)
124125
* [ ] New addresses are added to the `addresses_mainnet.sol`
125126
* [ ] Changes are tested via `testNewOrUpdatedChainlogValues`
127+
* [ ] Additions are tested via `testAddedChainlogKeys`
126128
* [ ] Adjust system values, collateral values inside `config.sol`
127129
* [ ] Ensure every spell variable is declared as public/internal
128130
* Add specific tests in `DssSpell.t.sol` to have sufficient test coverage for every spell action
129131
* [ ] Test new collaterals
130132
* [ ] Test new ilk registry values
131133
* [ ] Test new ChainLog values
132134
* [ ] Test DAI/MKR streams and payments, lerps
135+
* [ ] Test SKY streams and payments
133136
* [ ] Test the sum of all DAI/MKR payments matches the Exec Sheet
134137
* Run tests via `make test` (or `make test match=<test_name>` to inspect debug traces)
135138
* [ ] Ensure good coverage (every spell action is tested)

0 commit comments

Comments
 (0)