Skip to content

Commit 4c1dd49

Browse files
amusingaxloddaf
andauthored
chore: apply suggestions from code review
Co-authored-by: oddaf <[email protected]>
1 parent 1069a8a commit 4c1dd49

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

spell/rwa-checklists.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
* [ ] `RwaJar`
4646
* [ ] contract is verified on etherscan
4747
* [ ] ensure `0.6.12` solc version is used
48-
* [ ] ensure optimization are off
48+
* [ ] ensure optimizations are off
4949
* [ ] ensure license is specified (SPDX in code or otherwise)
5050
* [ ] ensure source matches [GitHub code](https://github.com/makerdao/rwa-toolkit/blob/8d30ed2cb657641253d45b57c894613e26b4ae1b/src/jars/RwaJar.sol) and it's consistent with previous RWA onboarding
5151
* [ ] constructor arg matches [`ChainLog`](https://chainlog.makerdao.com/)
@@ -54,7 +54,7 @@
5454
* [ ] `RwaInputConduit<2>`/`RwaSwapInputConduit<2>`
5555
* [ ] contract is verified on etherscan
5656
* [ ] ensure `0.6.12` solc version is used
57-
* [ ] ensure optimization are off
57+
* [ ] ensure optimizations are off
5858
* [ ] ensure license is specified (SPDX in code or otherwise)
5959
* [ ] ensure source matches [GitHub code](https://github.com/makerdao/rwa-toolkit/tree/8d30ed2cb657641253d45b57c894613e26b4ae1b/src/conduits) and it's consistent with previous RWA onboarding
6060
* [ ] constructor args are correct and match [chainlog](https://chainlog.makerdao.com/)
@@ -69,7 +69,7 @@
6969
* [ ] `RwaOutputConduit<2>`/`RwaSwapOutputConduit`
7070
* [ ] contract is verified on etherscan
7171
* [ ] ensure `0.6.12` solc version is used
72-
* [ ] ensure optimization are off
72+
* [ ] ensure optimizations are off
7373
* [ ] ensure license is specified (SPDX in code or otherwise)
7474
* [ ] ensure source matches [GitHub code](https://github.com/makerdao/rwa-toolkit/tree/8d30ed2cb657641253d45b57c894613e26b4ae1b/src/conduits) and it's consistent with previous RWA onboarding
7575
* [ ] constructor args are correct and match [chainlog](https://chainlog.makerdao.com/)
@@ -103,7 +103,7 @@
103103
* [ ] `hope` (operator, pause proxy)
104104
* [ ] `mate` (operator, pause proxy as fallback if required)
105105
* [ ] `kiss` (whitelist for `urn` destination address `who`)
106-
* [ ] Filable (`RwaSwapOutputConduit` and `RwaSwapInputConduit`)
106+
* [ ] Fileable (`RwaSwapOutputConduit` and `RwaSwapInputConduit`)
107107
* [ ] `quitTo` (`file` the appropriate address for conduits per technical assessment)
108108
* [ ] New Chainlog Entries
109109
* [ ] `RWAXYZ`

0 commit comments

Comments
 (0)