addressed PR comments

Author: 0xBasset

spell/spell-crafter-mainnet-workflow.md

@@ -126,11 +126,14 @@ Repo: https://github.com/makerdao/spells-mainnet
   * [ ] Adjust system values, collateral values inside `config.sol`
   * [ ] Ensure every spell variable is declared as public/internal
   * Bug Bounty Registry Updates
-    * [ ] Run `make safeharbor-generate` command in the `spells-mainnet` repo to check for bug bounty updates
-    * [ ] IF the command outputs a solidity snippet:
-      * [ ] Paste the generated code into the spell as is. The code should not be modified. You may adjust formatting.
-      * [ ] Import the `AGREEMENT_ADDRESS` from the `ChainLog`
-      * [ ] If not already present, add the helper function to perform the call, using the established archive pattern.  
+    * [ ] Check that output of make safeharbor-generate matches the instructions provided by Governance Facilitators
+      * [ ] If no instructions were provided and script produces "no changes", then no further action is required
+      * [ ] If there is a mismatch, crafter should notify Governance Facilitators
+      * [ ] If the scripts outputs a warning indicated by ⚠️ ❗, notify Governance Facilitators.
+      * [ ] If the command outputs a solidity snippet that matches the instructions provided by Governance Facilitators:
+        * [ ] Paste the generated code into the spell as is. The code should not be modified. You may adjust formatting
+        * [ ] Import the `AGREEMENT_ADDRESS` from the `ChainLog`
+        * [ ] If not already present, add the helper function to perform the call, using the established archive pattern.  
 * Add specific tests in `DssSpell.t.sol` to have sufficient test coverage for every spell action
   * [ ] Test new collaterals
   * [ ] Test new ilk registry values
@@ -225,7 +228,7 @@ Repo: https://github.com/makerdao/spells-mainnet
   * [ ] Create testnet and cast deployed spell there using `make cast-on-tenderly spell=0x...` command
   * [ ] Check that returned `public explorer url` is publicly accessible (e.g. using incognito browser mode)
   * [ ] IF `cast-on-tenderly` command is executed several times for the same spell, delete all testnets of the same name except the last one
-* [ ] Verify `make safeharbor-generate` returns empty diff in the casted environment after spell execution.
+* [ ] `make safeharbor-generate` returns empty diff in the testnet environment after spell was cast
 * [ ] Archive Spell via `make archive-spell` for the current date (or `make archive-spell date="YYYY-MM-DD"`) using Target Date inside the Exec Doc
 * [ ] Commit & push changes for review
 * [ ] Wait for CI to PASS

spell/spell-reviewer-mainnet-checklist.md

@@ -273,10 +273,12 @@
   * [ ] Target Contract is included in the ChainLog
   * [ ] Test Coverage is comprehensive
 * IF bug bounty registry updates are present
-  * [ ] Run `make safeharbor-generate` command passing the calldata in the spell to check for it's validity.
-  * [ ] Verify that the generated code exactly matches the generated code in the spell.
-  * [ ] Ensure that `AGREEMENT_ADDRESS` is imported from the ChainLog.
-  * [ ] Ensure that the helper function to perform the call is present and is implemented correctly.
+  * [ ] Run `make safeharbor-generate`
+    * [ ] Verify that the generated code exactly matches the code in the spell
+    * [ ] Verify that output matches the instructions provided by Governance Facilitators
+    * [ ] Ensure that the script does not output any warnings, which are indicated by ⚠️ ❗
+  * [ ] Ensure that agreement address is fetched from the Chainlog
+  * [ ] Ensure that the helper function to perform the call is present and is implemented using the established archive pattern
 * IF spell interacts with ChainLog
   * [ ] ChainLog version is incremented based on update type
     * Major -> New Vat (++.0.0)
@@ -388,7 +390,7 @@ _Insert your local test logs here_
   * [ ] All actions are executed in the transaction trace
   * [ ] No reverts are present that block execution
   * [ ] No out-of-gas errors are present
-  * [ ] Confirm `make safeharbor-generate` returns "no updates"
+  * [ ] `make safeharbor-generate` against the testnet returns "no updates"
 * Archive checks
   * [ ] `make diff-archive-spell` for current date or `make diff-archive-spell date="YYYY-MM-DD"`
   * [ ] Ensure date corresponds to target Exec Doc date