Skip to content

Commit 5a5ca34

Browse files
use IF statement
1 parent 3df27ec commit 5a5ca34

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

spell/spell-crafter-mainnet-workflow.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ Repo: https://github.com/makerdao/spells-mainnet
129129
* [ ] Ensure good coverage (every spell action is tested)
130130
* [ ] Ensure every test function is declared as `public`
131131
* [ ] IF the test needs to run, it MUST NOT have the `skipped` modifier; OTHERWISE, it MUST have the `skipped` modifier
132-
* Testing of modules initialised via the spell
132+
* IF a new module is initialized via the spell, the tests must include
133133
* [ ] Sanity checks of the constructor arguments
134134
* [ ] Sanity checks of all values added/updated by the spell function
135135
* [ ] End-to-end "happy path" interaction with the module

spell/spell-reviewer-mainnet-checklist.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@
314314
* [ ] Ensure each spell action has sufficient test coverage
315315
_List actions for which coverage was checked here_
316316
* [ ] Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of `printenv | grep "FOUNDRY_\|DAPP_"`)
317-
* Testing of modules initialised via the spell
317+
* IF a new module is initialized via the spell, the tests must include
318318
* [ ] Sanity checks of the constructor arguments
319319
* [ ] Sanity checks of all values added/updated by the spell function
320320
* [ ] End-to-end "happy path" interaction with the module

0 commit comments

Comments
 (0)