Skip to content

Commit 61630f4

Browse files
fix spellcheck
1 parent 7ea352c commit 61630f4

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.wordlist.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ Repo
6868
Solmate
6969
SPDX
7070
StairstepExponentialDecrease
71+
StarGuard
7172
Starknet
7273
SubDAO
7374
SubDAOs
@@ -90,6 +91,7 @@ authing
9091
bytecode
9192
casted
9293
checksummed
94+
codehash
9395
collateralization
9496
collaterals
9597
config

spell/star-spell-reviewer-checklist.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ This section outlines the review process and provides concrete action items for
152152
- [ ] IF a [StarGuard module](https://github.com/sky-ecosystem/star-guard) is onboarded for this Star, the following additional checks are done:
153153
- [ ] The spell exposes view-only interface `function isExecutable() external view returns (bool result)`.
154154
- [ ] `isExecutable` either simply returns `true` or implements additional logic communicated via the relevant forum post (e.g.: by describing "earliest launch date" or "office hours" logic, etc).
155-
- [ ] The test is preset to ensure that `isExecutable` outputs `true` before `StarGuard.maxDelay()` exires the spell.
155+
- [ ] The test is preset to ensure that `isExecutable` outputs `true` before `StarGuard.maxDelay()` expires the spell.
156156
- [ ] Third-party actors can not take advantage of the fact that Spell will be executed in a later block than the Core spell, otherwise suggest `direct execution`.
157157
- [ ] IF Prime spell can not be executed in a later block OR have to be executed sequentially to another Prime spell, `direct execution` is clearly proposed in the forum post together with elaborated explanation why it is needed.
158158
- [ ] The `direct execution` explanation makes sense on the technical level and can not be circumvented by the use of `isExecutable()` interface.

0 commit comments

Comments
 (0)