Skip to content

Commit a85c611

Browse files
Minor adjustments
1 parent 76c7d35 commit a85c611

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

spell/spell-crafter-mainnet-workflow.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ Repo: https://github.com/sky-ecosystem/spells-mainnet
115115
* IF addresses are used in the spell
116116
* [ ] Use `immutable` visibility when declaring addresses using `DssExecLib.getChangelogAddress`, OTHERWISE use `constant` for statically defined addresses
117117
* [ ] Fetch addresses as type `address` and wrap with `Like` suffix interfaces inline (when making calls), EXCEPT `MKR` and vesting contracts
118-
* [ ] Use the [DssExecLib address helpers](https://github.com/sky-ecosystem/dss-exec-lib/blob/master/src/DssExecLib.sol#L166) where possible (e.g. `DssExecLib.vat()`)
118+
* [ ] Use the [DssExecLib address helpers](https://github.com/sky-ecosystem/dss-exec-lib/blob/master/src/DssExecLib.sol#L192) where possible (e.g. `DssExecLib.vat()`)
119119
* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`), EXCEPT where the archive pattern differs from this pattern (e.g. `MKR`)
120120
* IF new addresses need to be added to the ChainLog
121121
* [ ] Add new addresses to the ChainLog

spell/spell-reviewer-mainnet-checklist.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
* [ ] Rate variable name conforms to `X_PT_Y_Z_PCT_RATE` (e.g. `ZERO_PT_SEVEN_FIVE_PCT_RATE` for 0.75%)
8282
* [ ] Rate variable visibility declared as `internal`
8383
* [ ] Rate variable state mutability declared as `constant`
84-
* [ ] Rates are defined in the ascending order (smallest to biggest)
84+
* [ ] Rates are defined in the ascending order (from smallest to largest)
8585
* IF timestamps are present
8686
* [ ] Comment above timestamp states full date including `UTC` timezone
8787
* [ ] Timestamp [converts](https://www.epochconverter.com/) back to the correct date

0 commit comments

Comments
 (0)