File tree Expand file tree Collapse file tree 2 files changed +17
-9
lines changed Expand file tree Collapse file tree 2 files changed +17
-9
lines changed Original file line number Diff line number Diff line change @@ -126,11 +126,16 @@ Repo: https://github.com/makerdao/spells-mainnet
126126  * [ ] Adjust system values, collateral values inside `config.sol` 
127127  * [ ] Ensure every spell variable is declared as public/internal 
128128  * Bug Bounty Registry Updates 
129-     * [ ] Run `make update-bug-bounty` command in the `spells-mainnet` repo to check for bug bounty updates 
130-     * [ ] IF the command outputs hex encoded calls: 
131-       * [ ] Add ALL output calls to the spell using low-level Solidity calls 
132-       * [ ] Each call MUST use the pattern: `(bool succ, bytes memory err) = AGREEMENT.call(<encodedDATA>);` 
133-       * [ ] Ensure proper error handling after each call (e.g., `require(succ, "Bug bounty update failed");`) 
129+     * [ ] Update safeharbor script 
130+       ```bash 
131+       cd scripts/safeharbor 
132+       npm install 
133+       ``` 
134+     * [ ] Run `npm run generate` command in the `spells-mainnet` repo to check for bug bounty updates 
135+     * [ ] IF the command outputs hex encoded call: 
136+       * [ ] Add ALL output call to the spell using low-level Solidity call. 
137+       * [ ] The call MUST use the pattern: `(bool succ, bytes memory err) = AGREEMENT.call(<encodedDATA>);` 
138+       * [ ] Ensure proper error handling after the call (e.g., `require(succ, "Bug bounty update failed");`) 
134139      * [ ] Add comment above the bug bounty section: `// ----- Bug Bounty Registry Updates -----` 
135140      * [ ] Include note: `// Note: Updates to bug bounty registry identified by make generate command` 
136141* Add specific tests in `DssSpell.t.sol` to have sufficient test coverage for every spell action 
Original file line number Diff line number Diff line change 273273  * [ ] Target Contract is included in the ChainLog 
274274  * [ ] Test Coverage is comprehensive 
275275* IF bug bounty registry updates are present 
276-   * [ ] Run `make update-bug-bounty` command independently to verify required updates 
277-   * [ ] Ensure ALL hex encoded calls from the command output are present in the spell 
278-   * [ ] Verify each call uses the correct pattern: `(bool succ, bytes memory err) = AGREEMENT.call(<encodedDATA>);` 
279-   * [ ] Cross-check that each `<encodedDATA>` exactly matches the script output 
276+   * [ ] Update safeharbor script 
277+     ```bash 
278+     cd scripts/safeharbor 
279+     npm install 
280+     ``` 
281+   * [ ] Run `npm run verify` command in the `spells-mainnet` repo, passing the calldata in the spell to check for it's validity. 
282+   * [ ] Verify the call uses the correct pattern: `(bool succ, bytes memory err) = AGREEMENT.call(<encodedDATA>);` 
280283  * [ ] Confirm proper error handling is implemented for each call 
281284  * [ ] Verify the bug bounty section has appropriate comments/documentation 
282285* IF spell interacts with ChainLog 
 
 
   
 
     
   
   
          
    
    
     
    
      
     
     
    You can’t perform that action at this time.
  
 
    
  
    
      
        
     
       
      
     
   
 
    
    
  
 
  
 
     
    
0 commit comments