Skip to content

Commit dc8b41f

Browse files
amusingaxloddaf
andauthored
refactor: address @oddaf's review suggestions.
Co-authored-by: oddaf <[email protected]>
1 parent 3752dc5 commit dc8b41f

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

spell/star-spell-reviewer-checklist.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,8 @@ This section outlines the review process, divided into several stages from devel
211211

212212
### Handover and Merge Stage
213213
- [ ] All review comments have been addressed.
214-
- [ ] At least 1 explicit approval review has been added to the PR.
215-
- [ ] The PR has been merged.
216-
- [ ] The spell address has been handed over to the responsible governance facilitator in the appropriate channel on Discord.
217-
- [ ] The Core spell crafter acknowledged the handover in the appropriate channel on Discord.
214+
* [ ] Check that the spell address posted by the crafter in the appropriate channel is correct
215+
* [ ] Confirm the address (via a separate "reply to" message, restating the address to avoid edits)
216+
* [ ] Wait until responsible governance facilitator confirms handover in `new-spells`
217+
* [ ] Ensure that no changes were made to the code since the spell was deployed and archived
218+
* [ ] Approve spell PR for merge via 'Approve' review option

0 commit comments

Comments
 (0)