You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* [ ] Check if oracle deployment is required (e.g. univ3-lp-oracle, new ilk pip, ...) with responsible ecosystem actor
114
114
* IF addresses are used in the spell
115
115
* [ ] Use `immutable` visibility when declaring addresses using `DssExecLib.getChangelogAddress`, OTHERWISE use `constant` for statically defined addresses
116
-
* [ ] Fetch addresses as type `address` and wrap with `Like` suffix interfaces inline (when making calls), EXCEPT `MKR` and vesting contracts
117
116
* [ ] Use the [DssExecLib address helpers](https://github.com/sky-ecosystem/dss-exec-lib/blob/master/src/DssExecLib.sol#L166) where possible (e.g. `DssExecLib.vat()`)
118
-
* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`), EXCEPT where the archive pattern differs from this pattern (e.g. `MKR`)
117
+
* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`)
119
118
* IF new addresses need to be added to the ChainLog
120
119
* [ ] Add new addresses to the ChainLog
121
120
* [ ] Increment ChainLog version, according to the update type
122
121
* Major -> New Vat (++.0.0)
123
122
* Minor -> Core Module (DSS) Update (e.g. Flapper) (0.++.0)
124
123
* Patch -> Collateral addition or addition/modification (0.0.++)
125
124
* [ ] New addresses are added to the `addresses_mainnet.sol`
126
-
* [ ] Changes are tested via `testNewOrUpdatedChainlogValues`
127
125
* [ ] Additions are tested via `testAddedChainlogKeys`
128
126
* [ ] Adjust system values, collateral values inside `config.sol`
129
127
* [ ] Ensure every spell variable is declared as public/internal
130
128
* Add specific tests in `DssSpell.t.sol` to have sufficient test coverage for every spell action
131
129
* [ ] Test new collaterals
132
130
* [ ] Test new ilk registry values
133
131
* [ ] Test new ChainLog values
134
-
* [ ] Test DAI/MKR streams and payments, lerps
132
+
* [ ] Test USDS/SKY streams and payments, lerps
135
133
* [ ] Test SKY streams and payments
136
-
* [ ] Test the sum of all DAI/MKR payments matches the Exec Sheet
134
+
* [ ] Test the sum of all USDS/SKY payments matches the Exec Sheet
137
135
* Run tests via `make test` (or `make test match=<test_name>` to inspect debug traces)
138
136
* [ ] Ensure good coverage (every spell action is tested)
139
137
* [ ] Ensure every test function is declared as `public`
0 commit comments