Skip to content

Commit ddea55c

Browse files
chore(spell-crafter-workflow): address review comments
1 parent 689e844 commit ddea55c

File tree

1 file changed

+3
-18
lines changed

1 file changed

+3
-18
lines changed

spell/spell-crafter-mainnet-workflow.md

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -113,27 +113,25 @@ Repo: https://github.com/sky-ecosystem/spells-mainnet
113113
* [ ] Check if oracle deployment is required (e.g. univ3-lp-oracle, new ilk pip, ...) with responsible ecosystem actor
114114
* IF addresses are used in the spell
115115
* [ ] Use `immutable` visibility when declaring addresses using `DssExecLib.getChangelogAddress`, OTHERWISE use `constant` for statically defined addresses
116-
* [ ] Fetch addresses as type `address` and wrap with `Like` suffix interfaces inline (when making calls), EXCEPT `MKR` and vesting contracts
117116
* [ ] Use the [DssExecLib address helpers](https://github.com/sky-ecosystem/dss-exec-lib/blob/master/src/DssExecLib.sol#L166) where possible (e.g. `DssExecLib.vat()`)
118-
* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`), EXCEPT where the archive pattern differs from this pattern (e.g. `MKR`)
117+
* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`)
119118
* IF new addresses need to be added to the ChainLog
120119
* [ ] Add new addresses to the ChainLog
121120
* [ ] Increment ChainLog version, according to the update type
122121
* Major -> New Vat (++.0.0)
123122
* Minor -> Core Module (DSS) Update (e.g. Flapper) (0.++.0)
124123
* Patch -> Collateral addition or addition/modification (0.0.++)
125124
* [ ] New addresses are added to the `addresses_mainnet.sol`
126-
* [ ] Changes are tested via `testNewOrUpdatedChainlogValues`
127125
* [ ] Additions are tested via `testAddedChainlogKeys`
128126
* [ ] Adjust system values, collateral values inside `config.sol`
129127
* [ ] Ensure every spell variable is declared as public/internal
130128
* Add specific tests in `DssSpell.t.sol` to have sufficient test coverage for every spell action
131129
* [ ] Test new collaterals
132130
* [ ] Test new ilk registry values
133131
* [ ] Test new ChainLog values
134-
* [ ] Test DAI/MKR streams and payments, lerps
132+
* [ ] Test USDS/SKY streams and payments, lerps
135133
* [ ] Test SKY streams and payments
136-
* [ ] Test the sum of all DAI/MKR payments matches the Exec Sheet
134+
* [ ] Test the sum of all USDS/SKY payments matches the Exec Sheet
137135
* Run tests via `make test` (or `make test match=<test_name>` to inspect debug traces)
138136
* [ ] Ensure good coverage (every spell action is tested)
139137
* [ ] Ensure every test function is declared as `public`
@@ -161,22 +159,9 @@ Repo: https://github.com/sky-ecosystem/spells-mainnet
161159
* [ ] Run `make exec-hash date=YYYY-MM-DD` and update spell code accordingly
162160
* [ ] Make sure generated hash matches with the hash provided from Governance Facilitator, OTHERWISE notify Responsible Governance Facilitator
163161
* [ ] Ensure that executive vote file name and date is correct
164-
* [ ] [community](https://github.com/sky-ecosystem/community) repo commit hash corresponds to latest change
165162
* [ ] [executive-votes](https://github.com/sky-ecosystem/executive-votes) repo commit hash corresponds to latest change
166163
* [ ] Raw GitHub URL is correct
167164
* [ ] Ensure the URL uses commit hash that introduced last change to the Exec Doc, NOT merge commit
168-
* [ ] IF there is no local copy of [`sky-ecosystem/community` GitHub repo](https://github.com/sky-ecosystem/community), run:
169-
```
170-
git clone https://github.com/sky-ecosystem/community
171-
```
172-
* [ ] OTHERWISE, ensure it is pointing to the latest commit on master:
173-
```
174-
git switch master && git pull origin master
175-
```
176-
* [ ] Get the latest commit hash for the exec doc:
177-
```
178-
git log --pretty=oneline -1 -- "<LOCAL_PATH_TO_EXEC_DOC>"
179-
```
180165
* [ ] IF there is no local copy of [`sky-ecosystem/executive-votes` GitHub repo](https://github.com/sky-ecosystem/executive-votes), run:
181166
```
182167
git clone https://github.com/sky-ecosystem/executive-votes

0 commit comments

Comments
 (0)