Skip to content

Commit fa99756

Browse files
committed
remove required comments
1 parent 5597823 commit fa99756

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

spell/spell-crafter-mainnet-workflow.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,6 @@ Repo: https://github.com/makerdao/spells-mainnet
131131
* [ ] Add the output hex encoded call to the spell using low-level Solidity call.
132132
* [ ] The call MUST use the pattern: `(bool succ, bytes memory err) = MULTICALL.call(<encodedDATA>);`
133133
* [ ] Ensure proper error handling after the call (e.g., `require(succ, "Bug bounty update failed");`)
134-
* [ ] Add comment above the bug bounty section: `// ----- Bug Bounty Registry Updates -----`
135-
* [ ] Include note: `// Note: Updates to bug bounty registry identified by make generate command`
136134
* Add specific tests in `DssSpell.t.sol` to have sufficient test coverage for every spell action
137135
* [ ] Test new collaterals
138136
* [ ] Test new ilk registry values

spell/spell-reviewer-mainnet-checklist.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@
275275
* IF bug bounty registry updates are present
276276
* [ ] Run `make safeharbor-verify calldata=<encodedDATA>` command passing the calldata in the spell to check for it's validity.
277277
* [ ] Verify the call uses the correct pattern: `(bool succ, bytes memory err) = MULTICALL.call(<encodedDATA>);`
278-
* [ ] Confirm proper error handling is implemented for each call
278+
* [ ] Confirm proper error handling is implemented for the call
279279
* [ ] Verify the bug bounty section has appropriate comments/documentation
280280
* IF spell interacts with ChainLog
281281
* [ ] ChainLog version is incremented based on update type

0 commit comments

Comments
 (0)