Fix cost review edge cases

Author: nadaverell

web/src/components/cost/CostView.test.ts

@@ -0,0 +1,12 @@
+import { describe, expect, it } from 'vitest'
+import { resourceKindForCostWorkload } from './CostView'
+
+describe('resourceKindForCostWorkload', () => {
+  it('does not link standalone aggregate rows as pods', () => {
+    expect(resourceKindForCostWorkload('standalone')).toBeNull()
+  })
+
+  it('keeps static pod rows linkable to their mirror pod', () => {
+    expect(resourceKindForCostWorkload('staticpod')).toBe('Pod')
+  })
+})

web/src/components/cost/CostView.tsx

@@ -614,8 +614,9 @@ function costWorkloadResource(wl: OpenCostWorkloadCost, namespace: string): Sele
   }
 }
 
-function resourceKindForCostWorkload(kind: string): string | null {
-  if (kind === 'standalone' || kind === 'staticpod') return 'Pod'
+export function resourceKindForCostWorkload(kind: string): string | null {
+  if (kind === 'staticpod') return 'Pod'
+  if (kind === 'standalone') return null
   if (kind === 'Deployment' || kind === 'StatefulSet' || kind === 'DaemonSet') return kind
   if (kind === 'Job' || kind === 'CronJob') return kind
   if (kind === 'Node') return kind

web/src/components/cost/WorkloadCostTab.test.ts

@@ -103,6 +103,28 @@ describe('getWorkloadCostState', () => {
   it('separates load failures from absent workload metrics', () => {
     expect(getWorkloadCostState(undefined, undefined, { currentError: true })).toBe('load_error')
   })
+
+  it('surfaces workload access and existence failures', () => {
+    const current: OpenCostWorkloadDetailResponse = {
+      available: false,
+      reason: 'access_denied',
+      namespace: 'prod',
+      kind: 'Deployment',
+      name: 'checkout',
+    }
+
+    const missing: OpenCostWorkloadTrendResponse = {
+      available: false,
+      reason: 'not_found',
+      namespace: 'prod',
+      kind: 'Deployment',
+      name: 'checkout',
+      range: '24h',
+    }
+
+    expect(getWorkloadCostState(current, undefined, false)).toBe('access_denied')
+    expect(getWorkloadCostState(undefined, missing, false)).toBe('not_found')
+  })
 })
 
 describe('buildLineChart', () => {

web/src/components/cost/WorkloadCostTab.tsx

@@ -83,7 +83,14 @@ export function WorkloadCostTab({ kind, namespace, name }: WorkloadCostTabProps)
     )
   }
 
-  if (state === 'no_prometheus' || state === 'no_metrics' || state === 'query_error' || state === 'load_error') {
+  if (
+    state === 'no_prometheus' ||
+    state === 'no_metrics' ||
+    state === 'query_error' ||
+    state === 'access_denied' ||
+    state === 'not_found' ||
+    state === 'load_error'
+  ) {
     const discoveryAgeMs = noPrometheusSince == null ? 0 : Date.now() - noPrometheusSince
     if (state === 'no_prometheus' && discoveryAgeMs < COST_DISCOVERY_GRACE_MS) {
       return (
@@ -282,7 +289,13 @@ export function getWorkloadCostState(
   if (loading) return 'loading'
 
   const reason = current?.reason ?? trend?.reason
-  if (reason === 'no_prometheus' || reason === 'query_error') return reason
+  if (
+    reason === 'no_prometheus' ||
+    reason === 'query_error' ||
+    reason === 'access_denied' ||
+    reason === 'not_found'
+  )
+    return reason
   return 'no_metrics'
 }
 
@@ -315,9 +328,13 @@ function WorkloadCostUnavailable({ state }: { state: CostUnavailableReason | 'lo
       ? 'Prometheus not found. OpenCost workload cost requires Prometheus or VictoriaMetrics.'
       : state === 'query_error'
         ? 'Cost data is temporarily unavailable. Prometheus was found, but workload cost queries failed.'
-        : state === 'load_error'
-          ? 'Could not load workload cost data. Check access to this workload and try again.'
-          : 'OpenCost workload metrics were not found for this workload.'
+        : state === 'access_denied'
+          ? 'You do not have access to view cost for this workload.'
+          : state === 'not_found'
+            ? 'This workload no longer exists.'
+            : state === 'load_error'
+              ? 'Could not load workload cost data. Check access to this workload and try again.'
+              : 'OpenCost workload metrics were not found for this workload.'
 
   return (
     <div className="flex h-full min-h-[320px] items-center justify-center">