Fix Ctrl+R desktop reload colliding with terminal reverse-search (#1133)

On Windows/Linux the native Wails Reload menu accelerator resolved to
Ctrl+R, the shell's reverse-i-search binding. Native menu accelerators
fire regardless of webview focus, so pressing Ctrl+R inside a
pod/local/node terminal reloaded the whole app instead of searching
history. macOS was unaffected (Cmd+R).

Pick the Reload accelerator per platform: keep Cmd+R on macOS, use
Ctrl+Shift+R on Windows/Linux. Terminals don't bind Ctrl+Shift+letter,
so it keeps a reload hotkey without shadowing a key the terminal sends
(plain function keys like F5 are consumed by TUIs and cmd.exe history).

Author: nadaverell

cmd/desktop/menu.go

@@ -1,11 +1,27 @@
 package main
 
 import (
+	goruntime "runtime"
+
 	"github.com/wailsapp/wails/v2/pkg/menu"
 	"github.com/wailsapp/wails/v2/pkg/menu/keys"
 	"github.com/wailsapp/wails/v2/pkg/runtime"
 )
 
+// reloadAccelerator picks the Reload shortcut per platform. Off macOS,
+// CmdOrCtrl+R resolves to Ctrl+R — the terminal's reverse-i-search binding — and
+// a native menu accelerator fires regardless of webview focus, so it would
+// hijack Ctrl+R inside a pod/local shell. Ctrl+Shift+R keeps a reload hotkey
+// without shadowing a key terminals actually send (plain function keys like F5
+// are consumed by TUIs and cmd.exe history). macOS keeps Cmd+R, which doesn't
+// collide (terminals use Ctrl, not Cmd).
+func reloadAccelerator(goos string) *keys.Accelerator {
+	if goos == "darwin" {
+		return keys.CmdOrCtrl("r")
+	}
+	return keys.Combo("r", keys.ControlKey, keys.ShiftKey)
+}
+
 func createMenu(desktopApp *DesktopApp, version string) *menu.Menu {
 	appMenu := menu.NewMenu()
 
@@ -70,7 +86,7 @@ func createMenu(desktopApp *DesktopApp, version string) *menu.Menu {
 		runtime.WindowExecJS(desktopApp.ctx, "window.history.forward()")
 	})
 	viewMenu.AddSeparator()
-	viewMenu.AddText("Reload", keys.CmdOrCtrl("r"), func(_ *menu.CallbackData) {
+	viewMenu.AddText("Reload", reloadAccelerator(goruntime.GOOS), func(_ *menu.CallbackData) {
 		runtime.WindowReloadApp(desktopApp.ctx)
 	})
 	viewMenu.AddSeparator()

cmd/desktop/menu_test.go

@@ -2,9 +2,11 @@ package main
 
 import (
 	"reflect"
+	goruntime "runtime"
 	"testing"
 
 	"github.com/wailsapp/wails/v2/pkg/menu"
+	"github.com/wailsapp/wails/v2/pkg/menu/keys"
 )
 
 func TestCreateMenuFileMenuExposesSupportedActions(t *testing.T) {
@@ -48,6 +50,43 @@ func TestCreateMenuNativeActionsHaveCallbacks(t *testing.T) {
 	}
 }
 
+func TestReloadAcceleratorAvoidsCtrlROffMac(t *testing.T) {
+	cases := []struct {
+		goos string
+		want *keys.Accelerator
+	}{
+		{"darwin", keys.CmdOrCtrl("r")},
+		{"windows", keys.Combo("r", keys.ControlKey, keys.ShiftKey)},
+		{"linux", keys.Combo("r", keys.ControlKey, keys.ShiftKey)},
+	}
+	for _, tc := range cases {
+		t.Run(tc.goos, func(t *testing.T) {
+			got := reloadAccelerator(tc.goos)
+			if !reflect.DeepEqual(got, tc.want) {
+				t.Fatalf("reloadAccelerator(%q) = %+v, want %+v", tc.goos, got, tc.want)
+			}
+		})
+	}
+}
+
+// TestCreateMenuReloadIsWiredToPlatformAccelerator asserts the Reload item uses
+// the platform-picked accelerator. On Linux CI (goruntime.GOOS == "linux") this
+// executes the non-mac branch for real, proving Ctrl+R is not bound to Reload.
+func TestCreateMenuReloadIsWiredToPlatformAccelerator(t *testing.T) {
+	appMenu := createMenu(&DesktopApp{}, "test")
+	reload := findMenuItem(t, findSubmenu(t, appMenu, "View"), "Reload")
+
+	if reload.Click == nil {
+		t.Fatal("Reload item has no callback")
+	}
+	if !reflect.DeepEqual(reload.Accelerator, reloadAccelerator(goruntime.GOOS)) {
+		t.Fatalf("Reload accelerator = %+v, want %+v", reload.Accelerator, reloadAccelerator(goruntime.GOOS))
+	}
+	if goruntime.GOOS != "darwin" && reflect.DeepEqual(reload.Accelerator, keys.CmdOrCtrl("r")) {
+		t.Fatalf("Reload is bound to Ctrl+R on %s — collides with terminal reverse-i-search", goruntime.GOOS)
+	}
+}
+
 func findSubmenu(t *testing.T, root *menu.Menu, label string) *menu.Menu {
 	t.Helper()
 	for _, item := range root.Items {