Skip to content

Commit 54e9359

Browse files
authored
Apply suggestions from code review
Co-authored-by: skylot <118523+skylot@users.noreply.github.com>
1 parent 6597a79 commit 54e9359

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

jadx-core/src/main/java/jadx/core/dex/visitors/rename/RenameVisitor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ private static void checkNames(RootNode root) {
7272
pkg.setLeafAlias(aliasProvider.forPackage(pkg), false);
7373
pkgUpdated = true;
7474
// verify the new name also doesn't conflict
75-
while (!pkgPaths.add(pkg.getAliasPkgInfo().getFullName().toLowerCase())) {
75+
if (!pkgPaths.add(pkg.getAliasPkgInfo().getFullName().toLowerCase())) {
7676
pkg.setLeafAlias(aliasProvider.forPackage(pkg), false);
7777
}
7878
}
@@ -90,7 +90,7 @@ private static void checkNames(RootNode root) {
9090
clsInfo.changeShortName(aliasProvider.forClass(cls));
9191
cls.addAttr(new RenameReasonAttr(cls).append("case insensitive filesystem"));
9292
// verify the new name also doesn't conflict
93-
while (!clsFullPaths.add(clsInfo.getAliasFullPath().toLowerCase())) {
93+
if (!clsFullPaths.add(clsInfo.getAliasFullPath().toLowerCase())) {
9494
clsInfo.changeShortName(aliasProvider.forClass(cls));
9595
}
9696
}

0 commit comments

Comments
 (0)