Skip to content

Commit bd74e1d

Browse files
committed
fix: try fix CodeQL checks
1 parent c5ae1f4 commit bd74e1d

1 file changed

Lines changed: 31 additions & 16 deletions

File tree

jadx-gui/src/main/java/jadx/gui/ui/hexeditor/buffer/ArrayByteBuffer.java

Lines changed: 31 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,14 @@ public ArrayByteBuffer(byte[] src) {
2525

2626
public ArrayByteBuffer(byte[] src, int offset, int length) {
2727
this.array = new byte[length];
28-
for (int i = 0; i < length; i++)
28+
for (int i = 0; i < length; i++) {
2929
this.array[i] = src[offset++];
30+
}
3031
}
3132

3233
@Override
3334
public boolean isEmpty() {
34-
return array.length <= 0;
35+
return array.length == 0;
3536
}
3637

3738
@Override
@@ -41,56 +42,69 @@ public long length() {
4142

4243
@Override
4344
public boolean get(long offset, byte[] dst, int dstOffset, int length) {
44-
if (length <= 0)
45+
if (length <= 0) {
4546
return true;
46-
for (int i = 0; i < length; i++)
47+
}
48+
for (int i = 0; i < length; i++) {
4749
dst[dstOffset++] = array[(int) offset++];
50+
}
4851
return true;
4952
}
5053

5154
@Override
5255
public boolean insert(long offset, byte[] src, int srcOffset, int length) {
53-
if (length <= 0)
56+
if (length <= 0) {
5457
return true;
58+
}
5559
long newLength = (long) array.length + (long) length;
56-
if (newLength < 0 || newLength > MAX_ARRAY_LENGTH)
60+
if (newLength > MAX_ARRAY_LENGTH) {
5761
return false;
62+
}
5863
byte[] newArray = new byte[(int) newLength];
5964
int ni = 0;
60-
for (int i = 0; i < offset; i++)
65+
for (int i = 0; i < (int) offset; i++) {
6166
newArray[ni++] = array[i];
62-
for (int i = 0; i < length; i++)
67+
}
68+
for (int i = 0; i < length; i++) {
6369
newArray[ni++] = src[srcOffset++];
64-
for (int i = (int) offset; i < array.length; i++)
70+
}
71+
for (int i = (int) offset; i < array.length; i++) {
6572
newArray[ni++] = array[i];
73+
}
6674
array = newArray;
6775
fireDataInserted(offset, length);
6876
return true;
6977
}
7078

7179
@Override
7280
public boolean overwrite(long offset, byte[] src, int srcOffset, int length) {
73-
if (length <= 0)
81+
if (length <= 0) {
7482
return true;
75-
for (int i = 0; i < length; i++)
83+
}
84+
for (int i = 0; i < length; i++) {
7685
array[(int) offset++] = src[srcOffset++];
86+
}
7787
fireDataOverwritten(offset, length);
7888
return true;
7989
}
8090

8191
@Override
8292
public boolean remove(long offset, long length) {
83-
if (length <= 0)
93+
if (length <= 0) {
8494
return true;
95+
}
8596
long newLength = (long) array.length - length;
86-
if (newLength < 0 || newLength > MAX_ARRAY_LENGTH)
97+
if (newLength < 0 || newLength > MAX_ARRAY_LENGTH) {
8798
return false;
99+
}
88100
byte[] newArray = new byte[(int) newLength];
89101
int ni = 0;
90-
for (int i = 0; i < offset; i++)
102+
for (int i = 0; i < (int) offset; i++) {
91103
newArray[ni++] = array[i];
92-
for (int i = (int) (offset + length); i < array.length; i++)
104+
}
105+
for (int i = (int) (offset + length); i < array.length; i++) {
93106
newArray[ni++] = array[i];
107+
}
94108
array = newArray;
95109
fireDataRemoved(offset, length);
96110
return true;
@@ -103,8 +117,9 @@ public ArrayByteBuffer slice(long offset, long length) {
103117

104118
@Override
105119
public boolean write(OutputStream out, long offset, long length) throws IOException {
106-
if (length <= 0)
120+
if (length <= 0) {
107121
return true;
122+
}
108123
out.write(array, (int) offset, (int) length);
109124
return true;
110125
}

0 commit comments

Comments
 (0)