Revert "fix: Use non-traditional RoPE in Qwen2 test case. (#56)" (#62)

jiengup · skyzh · web-flow · commit fa8b08ee765c · 2025-09-09T22:27:24.000-04:00
* Revert "fix: Use non-traditional RoPE in Qwen2 test case. (#56)" This reverts commit bf3383d. * Update week1-03-gqa.md with RoPE note and test command Added note about using non-traditional RoPE and testing command. --------- Co-authored-by: Alex Chi Z. <4198311+skyzh@users.noreply.github.com>
diff --git a/tests_refsol/test_week_1_day_3.py b/tests_refsol/test_week_1_day_3.py
@@ -158,7 +158,7 @@ def test_task_3_qwen2_grouped_query_attention(
             rms_norm_eps=1e-6,
             vocab_size=1000,
             rope_theta=theta,
-            rope_traditional=True,
+            rope_traditional=False,
             max_position_embeddings=max_seq_len,
         )
 

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ def test_task_3_qwen2_grouped_query_attention(`
`158`	`158`	`rms_norm_eps=1e-6,`
`159`	`159`	`vocab_size=1000,`
`160`	`160`	`rope_theta=theta,`
`161`		`- rope_traditional=True,`
	`161`	`+ rope_traditional=False,`
`162`	`162`	`max_position_embeddings=max_seq_len,`
`163`	`163`	`)`
`164`	`164`