Skip to content

Commit 4220d4b

Browse files
authored
fix a mistake in byrow argmax and argmin (#62)
threads argument should be passed to inner calls
1 parent ee78f24 commit 4220d4b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/byrow/row_functions.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -625,7 +625,7 @@ end
625625

626626
function row_argmin(ds::AbstractDataset, f::Function, cols = names(ds, Union{Missing, Number}); threads = true)
627627
colsidx = multiple_getindex(index(ds), cols)
628-
minvals = row_minimum(ds, f, cols)
628+
minvals = row_minimum(ds, f, cols; threads = threads)
629629
colnames_pa = allowmissing(PooledArray(_names(ds)[colsidx]))
630630
push!(colnames_pa, missing)
631631
missref = get(colnames_pa.invpool, missing, missing)
@@ -651,7 +651,7 @@ row_argmin(ds::AbstractDataset, cols = names(ds, Union{Missing, Number}); thread
651651

652652
function row_argmax(ds::AbstractDataset, f::Function, cols = names(ds, Union{Missing, Number}); threads = true)
653653
colsidx = multiple_getindex(index(ds), cols)
654-
maxvals = row_maximum(ds, f, cols)
654+
maxvals = row_maximum(ds, f, cols; threads = threads)
655655
colnames_pa = allowmissing(PooledArray(_names(ds)[colsidx]))
656656
push!(colnames_pa, missing)
657657
missref = get(colnames_pa.invpool, missing, missing)

0 commit comments

Comments
 (0)