Skip to content

Commit 137a0e3

Browse files
authored
Make LocalCircuitConfig more idiomatic (#355)
This isn't an "owner" type and should just be a standard `LocalCircuitConfig` convention
1 parent 291ec2d commit 137a0e3

4 files changed

Lines changed: 53 additions & 32 deletions

File tree

circuit/src/androidMain/baseline-prof.txt

Lines changed: 43 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

circuit/src/androidMain/kotlin/com/slack/circuit/NavigableCircuitContent.android.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public fun NavigableCircuitContent(
3737
navigator: Navigator,
3838
backstack: SaveableBackStack,
3939
modifier: Modifier = Modifier,
40-
circuitConfig: CircuitConfig = LocalCircuitOwner.current,
40+
circuitConfig: CircuitConfig = requireNotNull(LocalCircuitConfig.current),
4141
enableBackHandler: Boolean = true,
4242
providedValues: Map<out BackStack.Record, ProvidedValues> = providedValuesForBackStack(backstack),
4343
decoration: NavDecoration = NavigatorDefaults.DefaultDecoration,
@@ -62,7 +62,7 @@ public fun BasicNavigableCircuitContent(
6262
backstack: SaveableBackStack,
6363
providedValues: Map<out BackStack.Record, ProvidedValues>,
6464
modifier: Modifier = Modifier,
65-
circuitConfig: CircuitConfig = LocalCircuitOwner.current,
65+
circuitConfig: CircuitConfig = requireNotNull(LocalCircuitConfig.current),
6666
decoration: NavDecoration = NavigatorDefaults.EmptyDecoration,
6767
unavailableRoute: @Composable (String) -> Unit = NavigatorDefaults.UnavailableRoute,
6868
) {

0 commit comments

Comments
 (0)