Coverage

Author: sv2

examples/spectest/petstore.yaml

@@ -49,6 +49,7 @@ paths:
         name: "body"
         description: "Pet object that needs to be added to the store"
         required: true
+        x-ext-test: "Extension Test"
         schema:
           $ref: "#/definitions/Pet"
       responses:

lib/swsCoreStats.js

@@ -53,15 +53,7 @@ function swsCoreStats() {
         { hrtime: process.hrtime(), cpuUsage: process.cpuUsage() }
     ];
 
-    // prom-client metrics
-    this.promClientMetrics = null;
-
-}
-
-// Initialize
-swsCoreStats.prototype.initialize = function (swsOptions) {
-
-    // Create Prometheus Metrics in prom-client
+    // Prometheus metrics
     this.promClientMetrics = {};
 
     this.promClientMetrics.api_all_request_total = new promClient.Counter({
@@ -100,7 +92,11 @@ swsCoreStats.prototype.initialize = function (swsOptions) {
         name: swsUtil.swsMetrics.nodejs_process_cpu_usage_percentage.name,
         help: swsUtil.swsMetrics.nodejs_process_cpu_usage_percentage.help });
 
+}
 
+// Initialize
+swsCoreStats.prototype.initialize = function (swsOptions) {
+    // NOOP //
 };
 
 swsCoreStats.prototype.getStats = function () {
@@ -149,13 +145,11 @@ swsCoreStats.prototype.calculateSystemStats = function(ts,totalElapsedSec) {
     this.sys.cpu = cpuPercent;
 
     // Update prom-client metrics
-    if(this.promClientMetrics !== null) {
-        this.promClientMetrics.nodejs_process_memory_rss_bytes.set(this.sys.rss);
-        this.promClientMetrics.nodejs_process_memory_heap_total_bytes.set(this.sys.heapTotal);
-        this.promClientMetrics.nodejs_process_memory_heap_used_bytes.set(this.sys.heapUsed);
-        this.promClientMetrics.nodejs_process_memory_external_bytes.set(this.sys.external);
-        this.promClientMetrics.nodejs_process_cpu_usage_percentage.set(this.sys.cpu);
-    }
+    this.promClientMetrics.nodejs_process_memory_rss_bytes.set(this.sys.rss);
+    this.promClientMetrics.nodejs_process_memory_heap_total_bytes.set(this.sys.heapTotal);
+    this.promClientMetrics.nodejs_process_memory_heap_used_bytes.set(this.sys.heapUsed);
+    this.promClientMetrics.nodejs_process_memory_external_bytes.set(this.sys.external);
+    this.promClientMetrics.nodejs_process_cpu_usage_percentage.set(this.sys.cpu);
 };
 
 // Count request
@@ -172,10 +166,8 @@ swsCoreStats.prototype.countRequest = function (req, res) {
     this.method[method].countRequest(req.sws.req_clength);
 
     // Update prom-client metrics
-    if(this.promClientMetrics !== null){
-        this.promClientMetrics.api_all_request_total.inc();
-        this.promClientMetrics.api_all_request_in_processing_total.inc();
-    }
+    this.promClientMetrics.api_all_request_total.inc();
+    this.promClientMetrics.api_all_request_in_processing_total.inc();
 };
 
 
@@ -226,24 +218,22 @@ swsCoreStats.prototype.countResponse = function (res) {
         mstat.countResponse(res.statusCode,codeclass,duration,resContentLength);
     }
 
-    // Update prom-client metrics
-    if(this.promClientMetrics !== null){
-        switch(codeclass){
-            case "success":
-                this.promClientMetrics.api_all_success_total.inc();
-                break;
-            case "redirect":
-                this.promClientMetrics.api_all_errors_total.inc();
-                break;
-            case "client_error":
-                this.promClientMetrics.api_all_client_error_total.inc();
-                break;
-            case "server_error":
-                this.promClientMetrics.api_all_server_error_total.inc();
-                break;
-        }
-        this.promClientMetrics.api_all_request_in_processing_total.dec();
+    // Update Prometheus metrics
+    switch(codeclass){
+        case "success":
+            this.promClientMetrics.api_all_success_total.inc();
+            break;
+        case "redirect":
+            this.promClientMetrics.api_all_errors_total.inc();
+            break;
+        case "client_error":
+            this.promClientMetrics.api_all_client_error_total.inc();
+            break;
+        case "server_error":
+            this.promClientMetrics.api_all_server_error_total.inc();
+            break;
     }
+    this.promClientMetrics.api_all_request_in_processing_total.dec();
 
 };