fix(decode): Tests are now failing on negative dimensions

slashformotion · slashformotion · commit 92e80160b820 · 2022-02-16T15:23:42.000+01:00
diff --git a/reader.go b/reader.go
@@ -140,11 +140,11 @@ func (d *decoder) decodeHeader() error {
 		return errBadHeader
 	}
 	d.width, err = strconv.Atoi(string(headerFields[1]))
-	if err != nil {
+	if err != nil || d.width <= 0 {
 		return errBadHeader
 	}
 	d.height, err = strconv.Atoi(string(headerFields[2]))
-	if err != nil {
+	if err != nil || d.height <= 0 {
 		return errBadHeader
 	}
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -140,11 +140,11 @@ func (d *decoder) decodeHeader() error {`
`140`	`140`	`return errBadHeader`
`141`	`141`	`}`
`142`	`142`	`d.width, err = strconv.Atoi(string(headerFields[1]))`
`143`		`- if err != nil {`
	`143`	`+ if err != nil \|\| d.width <= 0 {`
`144`	`144`	`return errBadHeader`
`145`	`145`	`}`
`146`	`146`	`d.height, err = strconv.Atoi(string(headerFields[2]))`
`147`		`- if err != nil {`
	`147`	`+ if err != nil \|\| d.height <= 0 {`
`148`	`148`	`return errBadHeader`
`149`	`149`	`}`
`150`	`150`	`return nil`