Skip to content

[1.1.4] Migrations - Directly inheriting from ActiveRecord::Migration is not supported and Index name length #14

@tommyalvarez

Description

@tommyalvarez

Update wupee generator to support Rails 5. Currently the generator creates migration files like this:

class CreateWupeeNotificationTypes < ActiveRecord::Migration
  def change
    create_table :wupee_notification_types do |t|
      t.string :name
      t.timestamps null: false
    end

    add_index :wupee_notification_types, :name, unique: true
  end
end

When they should be like this (note the [5.1]):

class CreateWupeeNotificationTypes < ActiveRecord::Migration[5.1]
  def change
    create_table :wupee_notification_types do |t|
      t.string :name
      t.timestamps null: false
    end

    add_index :wupee_notification_types, :name, unique: true
  end
end

Also check index names length. They are being generated with a length > 63 which breaks on regular gem code base.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions