Incorporate review feedback by @tronical

Author: LeonMatthes

docs/astro/src/content/docs/reference/keyboard-input/overview.mdx

@@ -2,7 +2,7 @@
 title: Key Handling Overview
 description: Key Handling Overview
 ---
-{/* cSpell: ignore Backtab */}
+{/* cSpell: ignore Backtab WASD */}
 
 import Link from '@slint/common-files/src/components/Link.astro';
 import SpecialKeys from "/src/content/docs/reference/generated/enums/_keys.md"
@@ -104,10 +104,10 @@ As another example, `@keys(Control + Plus)` is equivalent to `@keys(Control + Sh
 
 ### Physical Key Bindings
 
-If you want to match a physical key position instead of the character produced on the current keyboard layout, use `@physical-keys(..)`.
+Use `@physical-keys(..)` to match a physical key position instead of the character produced on the current keyboard layout.
+For example, WASD bindings in a game should use `@physical-keys(..)` so the movement keys are always in the same position on all layouts.
 
-Physical key names reuse familiar `Key` names such as `A`, `Digit1`, `BackQuote`, or `LeftArrow`, but they refer to a physical key location instead of logical text.
-Today these names refer to positions on a U.S. keyboard layout.
+Physical key names reuse familiar `Key` names such as `A`, `Digit1`, `BackQuote`, or `LeftArrow`, but they refer to a physical key location on a U.S. keyboard layout, instead of logical text.
 Unlike `@keys(..)`, `@physical-keys(..)` does not currently accept string literals.
 
 ```slint

internal/compiler/builtins.slint

@@ -1322,6 +1322,8 @@ component MenuItem {
     /// The keyboard shortcut for this `MenuItem`.
     ///
     /// This property can only be set in a `MenuItem` that is part of a <Link type="MenuBar"/>.
+    ///
+    /// Only shortcuts created with @keys() are supported, @physical-keys() are not supported.
     in property <keys> shortcut;
     /// When true, a checkmark will be shown next to the title of the `MenuItem`.
     /// \default false

internal/compiler/passes/lower_menus.rs

@@ -664,13 +664,13 @@ fn lower_menu_items(
                     );
                 }
                 if in_menubar
-                    && let Some(binding) = element.borrow().bindings.get("shortcut")
-                    && matches!(&binding.borrow().expression, Expression::Keys(k) if k.is_physical)
+                    && let Some(binding) = element.borrow().binding("shortcut")
+                    && matches!(&binding.expression.ignore_debug_hooks(), Expression::Keys(k) if k.is_physical)
                 {
-                    diag.push_warning(
-                        "Physical keys in MenuItem shortcuts are interpreted as logical keys by native menu bars. Use @keys(...) for menu shortcuts instead"
+                    diag.push_error(
+                        "@physical-keys(..) in MenuItem shortcuts are not supported.\nUse @keys(...) for menu shortcuts instead"
                             .into(),
-                        &*binding.borrow(),
+                        &*binding,
                     );
                 }
 

internal/compiler/passes/resolving.rs

@@ -23,6 +23,7 @@ use i_slint_common::for_each_physical_keys;
 use smol_str::{SmolStr, ToSmolStr};
 use std::collections::BTreeMap;
 use std::rc::Rc;
+use std::sync::LazyLock;
 use unicode_segmentation::UnicodeSegmentation;
 
 mod remove_noop;
@@ -2179,12 +2180,10 @@ fn with_physical_key_map<R>(
         };
     }
 
-    thread_local! {
-        pub static PHYSICAL_KEY_MAP: std::collections::HashMap< &'static str, &'static str>  =
-            for_each_physical_keys!(generate_physical_key_map).into_iter().collect();
-    }
+    static PHYSICAL_KEY_MAP: LazyLock<std::collections::HashMap<&str, &str>> =
+        LazyLock::new(|| for_each_physical_keys!(generate_physical_key_map).into_iter().collect());
 
-    PHYSICAL_KEY_MAP.with(fun)
+    fun(&PHYSICAL_KEY_MAP)
 }
 
 fn lookup_physical_key(keycode: &str) -> Option<&'static str> {

internal/compiler/tests/syntax/elements/menu-shortcuts.slint

@@ -9,7 +9,7 @@ export component Test inherits Window {
             }
             MenuItem {
                 shortcut: @physical-keys(Control + N);
-//                        >                          <warning{Physical keys in MenuItem shortcuts are interpreted as logical keys by native menu bars. Use @keys(...) for menu shortcuts instead}
+//                        >                          <error{@physical-keys(..) in MenuItem shortcuts are not supported.↵Use @keys(...) for menu shortcuts instead}
             }
         }
     }