Skip to content

Commit fe9364e

Browse files
committed
ci: Fix specifying features for -Zminimal-versions
Was just appending to the end of the test command, so the features were actually being interpreted as a test filter. Need to run without --workspace/--all since the features are only valid for the main package.
1 parent e8f0b60 commit fe9364e

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/test.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,10 @@ jobs:
9898
# if there is a really good reason (like a dependency that requires a newer version).
9999
continue-on-error: false
100100
- name: Test (-Zminimal-versions)
101-
run:
102-
cargo minimal-versions test --all --verbose --no-default-features "${{ matrix.features }}"
101+
# NOTE: Use of --all here means features must be defined for the entire workspace
102+
# Since the default package is the only published package, the flag is not strictly necessary
103+
run: |
104+
cargo minimal-versions test --verbose --no-default-features --features "${{ matrix.features }}"
103105
- name: rustdoc
104106
# Restrict to working on nightly/stable (old versions might have undefined types)
105107
if: ${{ matrix.rust == 'nightly' || matrix.rust == 'stable' }}

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
88

99
### Fixed
1010
* Get `anyhow` working with `-Zminimal-versions`: `AsRef` impl was not present in 1.0.0
11+
* ci: Fix testing `-Zminimal-versions` with non-default features
1112

1213
## 2.8.2 - 2025-10-11
1314

0 commit comments

Comments
 (0)