Provenance v1: re-add completeness and reproducibility
#765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
These were removed from an earlier draft of v1 when we made it implicit from `builder.id`, but there has been feedback that it is valuable even if implicit. Now the values are enums (for extensibility) and are restricting to being strictly stronger than the implicit value from `builder.id`. Signed-off-by: Mark Lodato <[email protected]>
MarkLodato
force-pushed
the
completeness-716
branch
from
cea7ea5 to
d9491ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were removed from an earlier draft of v1 when we made it implicit from
builder.id, but there has been feedback that it is valuable even if implicit. Now the values are enums (for extensibility) and are restricting to being strictly stronger than the implicit value frombuilder.id.This is a draft for comments based on the discussion in #716. I am not 100% confident in this, but I wanted to create this PR to see what people thought. Opinions welcome!
Fixes #716 (I hope!)
/cc @tonistiigi @jedevc @patricklawsongoogle @bobcatfish @chitrangpatel @khalkie