make: *** [Makefile:134: test] Error 1 build from source #618

andrei-kondakov · 2021-06-25T15:53:04Z

andrei-kondakov
Jun 25, 2021

Hi!

I'm trying to build from the source and got following errors on ubuntu 20.04:

root@ca:~# git clone --branch v0.15.15  https://github.com/smallstep/certificates.git 
root@ca:~# cd certificates/
root@ca:~/certificates# make bootstrap && make
# Using a released version of golangci-lint to take into account custom replacements in their go.mod
golangci/golangci-lint info checking GitHub for tag 'v1.39.0'
golangci/golangci-lint info found version: 1.39.0 for v1.39.0/linux/amd64
golangci/golangci-lint info installed /bin/golangci-lint
ok  	github.com/smallstep/certificates/acme	5.264s	coverage: 66.6% of statements
ok  	github.com/smallstep/certificates/acme/api	0.101s	coverage: 90.6% of statements
ok  	github.com/smallstep/certificates/acme/db/nosql	0.017s	coverage: 95.8% of statements
ok  	github.com/smallstep/certificates/api	2.750s	coverage: 76.5% of statements
ok  	github.com/smallstep/certificates/authority	0.612s	coverage: 79.5% of statements
ok  	github.com/smallstep/certificates/authority/provisioner	10.895s	coverage: 85.9% of statements
ok  	github.com/smallstep/certificates/ca	30.300s	coverage: 66.5% of statements
2021/06/25 15:45:37 http: TLS handshake error from 127.0.0.1:42972: read tcp 127.0.0.1:43781->127.0.0.1:42972: use of closed network connection
--- FAIL: TestWriteDefaultIdentity (0.00s)
    --- FAIL: TestWriteDefaultIdentity/fail_certificate (0.00s)
        identity_test.go:264: WriteDefaultIdentity() error = <nil>, wantErr true
    --- FAIL: TestWriteDefaultIdentity/fail_write_identity (0.00s)
        identity_test.go:264: WriteDefaultIdentity() error = <nil>, wantErr true
--- FAIL: TestIdentity_Renew (0.00s)
    --- FAIL: TestIdentity_Renew/fail_write_identity (0.00s)
        identity_test.go:448: Identity.Renew() error = <nil>, wantErr true
FAIL
coverage: 91.9% of statements
FAIL	github.com/smallstep/certificates/ca/identity	0.020s
ok  	github.com/smallstep/certificates/cas	0.002s	coverage: 95.0% of statements
ok  	github.com/smallstep/certificates/cas/apiv1	0.003s	coverage: 97.1% of statements
ok  	github.com/smallstep/certificates/cas/cloudcas	0.033s	coverage: 96.7% of statements
ok  	github.com/smallstep/certificates/cas/softcas	0.006s	coverage: 96.0% of statements
ok  	github.com/smallstep/certificates/cas/stepcas	1.477s	coverage: 95.9% of statements
?   	github.com/smallstep/certificates/cmd/step-awskms-init	[no test files]
?   	github.com/smallstep/certificates/cmd/step-ca	[no test files]
?   	github.com/smallstep/certificates/cmd/step-cloudkms-init	[no test files]
?   	github.com/smallstep/certificates/cmd/step-pkcs11-init	[no test files]
?   	github.com/smallstep/certificates/cmd/step-yubikey-init	[no test files]
?   	github.com/smallstep/certificates/commands	[no test files]
ok  	github.com/smallstep/certificates/db	0.003s	coverage: 18.1% of statements
ok  	github.com/smallstep/certificates/errs	0.002s	coverage: 8.9% of statements
?   	github.com/smallstep/certificates/examples/basic-client	[no test files]
?   	github.com/smallstep/certificates/examples/basic-federation/client	[no test files]
?   	github.com/smallstep/certificates/examples/basic-federation/server	[no test files]
?   	github.com/smallstep/certificates/examples/bootstrap-client	[no test files]
?   	github.com/smallstep/certificates/examples/bootstrap-mtls-server	[no test files]
?   	github.com/smallstep/certificates/examples/bootstrap-tls-server	[no test files]
ok  	github.com/smallstep/certificates/kms	0.009s	coverage: 100.0% of statements
ok  	github.com/smallstep/certificates/kms/apiv1	0.002s	coverage: 82.9% of statements
ok  	github.com/smallstep/certificates/kms/awskms	0.004s	coverage: 98.5% of statements
ok  	github.com/smallstep/certificates/kms/cloudkms	10.008s	coverage: 98.4% of statements
?   	github.com/smallstep/certificates/kms/pkcs11	[no test files]
ok  	github.com/smallstep/certificates/kms/softkms	1.646s	coverage: 95.7% of statements
ok  	github.com/smallstep/certificates/kms/sshagentkms	0.034s	coverage: 85.9% of statements
ok  	github.com/smallstep/certificates/kms/uri	0.002s	coverage: 100.0% of statements
?   	github.com/smallstep/certificates/kms/yubikey	[no test files]
ok  	github.com/smallstep/certificates/logging	0.002s	coverage: 30.0% of statements
?   	github.com/smallstep/certificates/monitoring	[no test files]
?   	github.com/smallstep/certificates/pki	[no test files]
?   	github.com/smallstep/certificates/server	[no test files]
--- FAIL: TestOutput_Write (0.00s)
    --- FAIL: TestOutput_Write/snippetErr (0.00s)
        templates_test.go:413: Output.Write() error = <nil>, wantErr true
    --- FAIL: TestOutput_Write/fileErr (0.00s)
        templates_test.go:413: Output.Write() error = <nil>, wantErr true
    --- FAIL: TestOutput_Write/directoryErr (0.00s)
        templates_test.go:413: Output.Write() error = <nil>, wantErr true
FAIL
coverage: 94.1% of statements
FAIL	github.com/smallstep/certificates/templates	0.014s
FAIL
make: *** [Makefile:134: test] Error 1

maraino · 2021-06-28T19:26:39Z

maraino
Jun 28, 2021
Maintainer

What OS, architecture, and Go version are you using, I cannot reproduce the errors on my machine, and the build system was able to create the release.

4 replies

andrei-kondakov Jun 30, 2021
Author

Ubuntu 20.04.2 LTS (GNU/Linux 5.4.0-77-generic x86_64)
amd64
go 1.16.5

maraino Jul 6, 2021
Maintainer

The first error might be some iptables rules, but it should be weird but the second error doesn't make more sense. Can you try if you see this error:

$ mkdir /tmp/bad 
$ chmod 644 /tmp/bad
$ touch /tmp/bad/foo
touch: cannot touch '/tmp/bad/foo': Permission denied

If not, can you show me the permissions of /tmp/bad (stat /tmp/bad)

And are the test run ok if you run them manually?

$ go test ./ca/identity --run TestWriteDefaultIdentity
ok  	github.com/smallstep/certificates/ca/identity	0.021s
$ go test ./ca/identity --run TestIdentity_Renew
ok  	github.com/smallstep/certificates/ca/identity	0.019s
$ go test ./templates --run TestOutput_Write
ok  	github.com/smallstep/certificates/templates	0.007s

andrei-kondakov Jul 12, 2021
Author

@maraino sorry for late response

If not, can you show me the permissions of /tmp/bad (stat /tmp/bad)

root@ca:~# mkdir /tmp/bad
root@ca:~# chmod 644 /tmp/bad
root@ca:~# touch /tmp/bad/foo
root@ca:~# stat /tmp/bad
  File: /tmp/bad
  Size: 4096      	Blocks: 8          IO Block: 4096   directory
Device: fc01h/64513d	Inode: 128333      Links: 2
Access: (0644/drw-r--r--)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2021-07-12 15:21:25.771735720 +0000
Modify: 2021-07-12 15:21:35.315714757 +0000
Change: 2021-07-12 15:21:35.315714757 +0000
 Birth: -

And are the test run ok if you run them manually?

oot@ca:~/certificates# go test ./ca/identity --run TestWriteDefaultIdentity
--- FAIL: TestWriteDefaultIdentity (0.01s)
    --- FAIL: TestWriteDefaultIdentity/fail_certificate (0.00s)
        identity_test.go:264: WriteDefaultIdentity() error = <nil>, wantErr true
    --- FAIL: TestWriteDefaultIdentity/fail_write_identity (0.00s)
        identity_test.go:264: WriteDefaultIdentity() error = <nil>, wantErr true
FAIL
FAIL	github.com/smallstep/certificates/ca/identity	0.013s
FAIL

root@ca:~/certificates# go test ./ca/identity --run TestIdentity_Renew
--- FAIL: TestIdentity_Renew (0.01s)
    --- FAIL: TestIdentity_Renew/fail_write_identity (0.00s)
        identity_test.go:448: Identity.Renew() error = <nil>, wantErr true
FAIL
FAIL	github.com/smallstep/certificates/ca/identity	0.015s
FAIL

root@ca:~/certificates# go test ./templates --run TestOutput_Write
go: downloading github.com/smallstep/assert v0.0.0-20200723003110-82e2b9b3b262
--- FAIL: TestOutput_Write (0.00s)
    --- FAIL: TestOutput_Write/snippetErr (0.00s)
        templates_test.go:413: Output.Write() error = <nil>, wantErr true
    --- FAIL: TestOutput_Write/fileErr (0.00s)
        templates_test.go:413: Output.Write() error = <nil>, wantErr true
    --- FAIL: TestOutput_Write/directoryErr (0.00s)
        templates_test.go:413: Output.Write() error = <nil>, wantErr true
FAIL
FAIL	github.com/smallstep/certificates/templates	0.005s
FAIL

maraino Jul 13, 2021
Maintainer

All three errors are because for some reason in your system you can write on directories that do not have the execution permission. Perhaps there is some mount option that allows you to do that.

I suppose it would be ok to change those directories permissions to 0500 or 0544 to remove the write permission instead of the execution and the test should be valid.

Can you try to submit a PR changing on the tests that are failing the permissions of MkdirAll and Mkdir from 0600 to 0500 and 0644 to 0544 if they work for you?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make: *** [Makefile:134: test] Error 1 build from source #618

{{title}}

Replies: 1 comment 4 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

Select a reply

make: *** [Makefile:134: test] Error 1 build from source #618

andrei-kondakov Jun 25, 2021

Replies: 1 comment · 4 replies

maraino Jun 28, 2021 Maintainer

andrei-kondakov Jun 30, 2021 Author

maraino Jul 6, 2021 Maintainer

andrei-kondakov Jul 12, 2021 Author

maraino Jul 13, 2021 Maintainer

andrei-kondakov
Jun 25, 2021

Replies: 1 comment 4 replies

maraino
Jun 28, 2021
Maintainer

andrei-kondakov Jun 30, 2021
Author

maraino Jul 6, 2021
Maintainer

andrei-kondakov Jul 12, 2021
Author

maraino Jul 13, 2021
Maintainer