fix(050): consistent disabled-server handling + verification

Related #437

Global handler now uses the management-service GetServerTools path (same
as the per-server endpoint) so a disabled/not-connected server yields an
empty tool set instead of a false partial:true/failed_servers flag.
Adjusted the unit-test controller to exercise the controller fallback
path. Adds the Playwright sweep (5/5 green), self-contained HTML report,
and screenshots under verification/.

Author: Algis Dumbris

internal/httpapi/server.go

@@ -2514,6 +2514,22 @@ func (s *Server) handleGetGlobalTools(w http.ResponseWriter, r *http.Request) {
 		usage = map[string]storage.ToolUsageStat{}
 	}
 
+	// Use the same management-service path as the per-server tools endpoint so
+	// behaviour is consistent: a disabled / not-connected server returns an
+	// empty tool set (NOT an error), so it contributes zero tools without
+	// being mislabelled as a failed server. Fall back to the controller path
+	// when the management service is unavailable (keeps unit tests + minimal
+	// deployments working).
+	mgmtSvc, hasMgmt := s.controller.GetManagementService().(interface {
+		GetServerTools(ctx context.Context, name string) ([]map[string]interface{}, error)
+	})
+	getTools := func(name string) ([]map[string]interface{}, error) {
+		if hasMgmt {
+			return mgmtSvc.GetServerTools(r.Context(), name)
+		}
+		return s.controller.GetServerTools(name)
+	}
+
 	resp := contracts.GlobalToolsResponse{
 		Tools: make([]contracts.Tool, 0, 256),
 	}
@@ -2524,9 +2540,10 @@ func (s *Server) handleGetGlobalTools(w http.ResponseWriter, r *http.Request) {
 			continue
 		}
 
-		generic, terr := s.controller.GetServerTools(name)
+		generic, terr := getTools(name)
 		if terr != nil {
-			// Spec edge case: still return every tool we could gather.
+			// Spec edge case: a genuine fetch error — still return every tool
+			// we could gather, flag the rest as partial.
 			resp.Partial = true
 			resp.FailedServers = append(resp.FailedServers, name)
 			s.logger.Debug("Global tools: server tools fetch failed", "server", name, "error", terr)

internal/httpapi/server_global_tools_test.go

@@ -27,6 +27,11 @@ type globalToolsController struct {
 	usageErr     error
 }
 
+// GetManagementService returns nil so handleGetGlobalTools exercises the
+// controller GetServerTools path this mock controls. The management-service
+// path is verified end-to-end via the API E2E + curl verification.
+func (m *globalToolsController) GetManagementService() interface{} { return nil }
+
 func (m *globalToolsController) GetAllServers() ([]map[string]interface{}, error) {
 	return m.allServers, nil
 }

specs/050-global-tools-page/execution_log.md

@@ -5,3 +5,11 @@ State file per CLAUDE.md autonomous-operation constraint. One line per completed
 - 2026-05-18 brainstormed feature with user; design approved (aggregation endpoint, v1 columns, substring search, replace orphaned Tools.vue).
 - 2026-05-18 speckit.specify → spec.md + checklists/requirements.md committed (3633b6e5). SynapBus SPEC announcement posted (#my-agents-algis, msg 37429).
 - 2026-05-18 CLI gap analysis: `tools list` requires --server, name+desc only; no per-tool enable/disable CLI. Decision: fold CLI parity into spec 050 (same endpoint/feature), not a new spec.
+- 2026-05-18 backend impl (T002-T012): AggregateToolUsage + GET /api/v1/tools + helper refactor; httpapi/storage/runtime/server tests GREEN, lint clean.
+- 2026-05-18 fanned out frontend (Tools.vue rewrite, /tools route, sidebar badge, US1-3) + CLI (US4 global list + enable/disable) subagents; both reported GREEN (frontend build clean, cmd tests pass).
+- 2026-05-18 live curl: found+fixed false partial:true — global handler now uses mgmt-service GetServerTools (like per-server endpoint) so disabled/not-connected servers yield 0 tools, not a 'failed' flag. Re-verified: 13 tools, partial absent, stats consistent. CLI table OK.
+- 2026-05-18 FR-001 note: a disabled server that was NEVER connected has no tools anywhere (index empty, per-server endpoint returns 0). Showing its tools is impossible by any path; this is an inherent limitation, distinct from the 'server errored -> partial' edge case (now correctly separated). Documented as refined assumption.
+- 2026-05-18 API E2E: GET /api/v1/tools PASS. 10 unrelated pre-existing/environmental failures (upstream_servers env/args/headers CRUD hitting example.com, flaky activity/{id}) — none in tools code paths.
+- 2026-05-18 Playwright sweep 5/5 GREEN (loaded table, search, sort, batch-bar+disable, empty state); self-contained report.html + screenshots committed under verification/.
+- 2026-05-18 chrome-ext live check: page matches issue #437 mockup (sidebar Tools badge=13, 4 stat cards, filter bar, dense table). Verified batch-disable works end-to-end (Playwright run disabled all 13; curl confirms disabled:13, frontend cards reflect backend stats — consistent, no bug).
+- 2026-05-18 final: golangci-lint 0 issues, frontend build clean, go tests GREEN. Ready for PR.

specs/050-global-tools-page/verification/01-loaded-table.png

@@ -0,0 +1,11 @@
+import { defineConfig } from '@playwright/test';
+export default defineConfig({
+  testDir: '.', timeout: 40000, fullyParallel: false, workers: 1, retries: 0,
+  use: {
+    headless: true,
+    viewport: { width: 1440, height: 900 },
+    launchOptions: {
+      executablePath: '/Users/user/Library/Caches/ms-playwright/chromium-1217/chrome-mac-arm64/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing',
+    },
+  },
+});