Skip to content

Commit b1faef4

Browse files
Dumbrisclaude
andauthored
chore(ci): align workflow frontend-copy with Makefile frontend-build (#474)
PR #473 changed the Makefile `frontend-build` target to copy into `web/frontend/dist/` and `touch web/frontend/dist/.gitkeep` (so the `//go:embed all:frontend/dist` directive always has something to embed). The release.yml and pr-build.yml "Copy frontend dist" steps still used the older `cp -r frontend/dist web/frontend/` form. Both forms place a real index.html under web/frontend/dist/ so release artifacts were never broken, but the divergent forms are confusing and the workflow steps did not recreate the tracked .gitkeep. This aligns both workflows with the Makefile so there is a single canonical form. Follow-up to #473. No functional change to release/CI artifacts. Co-authored-by: Claude Code <noreply@anthropic.com>
1 parent 7a1f6fd commit b1faef4

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

.github/workflows/pr-build.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,11 @@ jobs:
176176
shell: bash
177177
run: |
178178
rm -rf web/frontend
179-
mkdir -p web/frontend
180-
cp -r frontend/dist web/frontend/
179+
mkdir -p web/frontend/dist
180+
cp -r frontend/dist/. web/frontend/dist/
181+
# Recreate the tracked .gitkeep so //go:embed all:frontend/dist
182+
# always has something to embed (matches the Makefile frontend-build target).
183+
touch web/frontend/dist/.gitkeep
181184
182185
- name: Run tests (skip binary E2E tests - not compatible with cross-compilation)
183186
# Skip tests for Windows ARM64 (cross-compilation - can't run ARM64 binaries on AMD64 runner)

.github/workflows/release.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,8 +294,11 @@ jobs:
294294
shell: bash
295295
run: |
296296
rm -rf web/frontend
297-
mkdir -p web/frontend
298-
cp -r frontend/dist web/frontend/
297+
mkdir -p web/frontend/dist
298+
cp -r frontend/dist/. web/frontend/dist/
299+
# Recreate the tracked .gitkeep so //go:embed all:frontend/dist
300+
# always has something to embed (matches the Makefile frontend-build target).
301+
touch web/frontend/dist/.gitkeep
299302
300303
- name: Import Code-Signing Certificates (macOS)
301304
if: matrix.goos == 'darwin'

0 commit comments

Comments
 (0)