Support legacy field in protobuf layer.

Author: winder

execute/observation.go

@@ -48,11 +48,6 @@ func (p *Plugin) Observation(
 	}
 	lggr.Infow("decoded previous outcome", "previousOutcome", previousOutcome)
 
-	// TODO: Support "Reports" field.
-	if len(previousOutcome.Reports) > 0 {
-		previousOutcome.Report = previousOutcome.Reports[0]
-	}
-
 	// If the previous outcome was the filter state, and reports were built, mark the messages as inflight.
 	if previousOutcome.State == exectypes.Filter {
 		for _, chainReport := range previousOutcome.Report.ChainReports {

execute/outcome.go

@@ -35,11 +35,6 @@ func (p *Plugin) Outcome(
 		return nil, fmt.Errorf("unable to decode previous outcome: %w", err)
 	}
 
-	// TODO: Support "Reports" field.
-	if len(previousOutcome.Reports) > 0 {
-		previousOutcome.Report = previousOutcome.Reports[0]
-	}
-
 	state := previousOutcome.State.Next()
 	lggr = logger.With(lggr, "execPluginState", state)
 	lggr.Debugw("Execute plugin performing outcome",

execute/plugin.go

@@ -358,11 +358,6 @@ func (p *Plugin) ValidateObservation(
 		return fmt.Errorf("unable to decode previous outcome: %w", err)
 	}
 
-	// TODO: Support "Reports" field.
-	if len(previousOutcome.Reports) > 0 {
-		previousOutcome.Report = previousOutcome.Reports[0]
-	}
-
 	supportedChains, err := p.supportedChains(ao.Observer)
 	if err != nil {
 		return fmt.Errorf("error finding supported chains by node: %w", err)
@@ -564,11 +559,6 @@ func (p *Plugin) Reports(
 		return nil, fmt.Errorf("unable to decode outcome: %w", err)
 	}
 
-	// TODO: Support "Reports" field.
-	if len(decodedOutcome.Reports) > 0 {
-		decodedOutcome.Report = decodedOutcome.Reports[0]
-	}
-
 	if len(decodedOutcome.Report.ChainReports) == 0 {
 		lggr.Warn("empty report", "report", decodedOutcome.Report)
 		return nil, nil

execute/tracked.go

@@ -103,9 +103,6 @@ func currentState(p *TrackedPlugin, outctx ocr3types.OutcomeContext) exectypes.P
 	}
 
 	// TODO: Support "Reports" field.
-	if len(out.Reports) > 0 {
-		out.Report = out.Reports[0]
-	}
 
 	return out.State.Next()
 }

pkg/ocrtypecodec/v1/exec.go

@@ -120,6 +120,12 @@ func (e *ExecCodecProto) DecodeOutcome(data []byte) (exectypes.Outcome, error) {
 		outc.Reports = e.tr.execPluginReportsFromProto([]*ocrtypecodecpb.ExecutePluginReport{pbOutc.ExecutePluginReport})
 	}
 
+	// Decode the new report format into the legacy field as an intermediate step for implementing this feature.
+	// TODO: Remove temporary function after the 'Reports' field is fully implemented.
+	if len(outc.Reports) > 0 {
+		outc.Report = outc.Reports[0]
+	}
+
 	return outc, nil
 }