Fix bug where ValidAfterSeconds is wrong (#82)

samsondav · web-flow · commit 06ab16d728d3 · 2024-10-08T10:33:51.000-04:00
diff --git a/llo/plugin_outcome.go b/llo/plugin_outcome.go
@@ -237,11 +237,9 @@ func (p *Plugin) outcome(outctx ocr3types.OutcomeContext, query types.Query, aos
 				if p.Config.VerboseLogging {
 					p.Logger.Debugw("Channel is not reportable", "channelID", channelID, "err", err3, "stage", "Outcome", "seqNr", outctx.SeqNr)
 				}
-				// was reported based on previous outcome
-				outcome.ValidAfterSeconds[channelID] = previousObservationsTimestampSeconds
-			} else {
-				// was skipped based on previous outcome
 				outcome.ValidAfterSeconds[channelID] = previousValidAfterSeconds
+			} else {
+				outcome.ValidAfterSeconds[channelID] = previousObservationsTimestampSeconds
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -237,11 +237,9 @@ func (p *Plugin) outcome(outctx ocr3types.OutcomeContext, query types.Query, aos`
`237`	`237`	`if p.Config.VerboseLogging {`
`238`	`238`	`p.Logger.Debugw("Channel is not reportable", "channelID", channelID, "err", err3, "stage", "Outcome", "seqNr", outctx.SeqNr)`
`239`	`239`	`}`
`240`		`- // was reported based on previous outcome`
`241`		`- outcome.ValidAfterSeconds[channelID] = previousObservationsTimestampSeconds`
`242`		`- } else {`
`243`		`- // was skipped based on previous outcome`
`244`	`240`	`outcome.ValidAfterSeconds[channelID] = previousValidAfterSeconds`
	`241`	`+ } else {`
	`242`	`+ outcome.ValidAfterSeconds[channelID] = previousObservationsTimestampSeconds`
`245`	`243`	`}`
`246`	`244`	`}`
`247`	`245`	`}`