Add unit test for DF Cache being able to have multiple Workflows write to a Data ID (#16982)

Author: alecgard

contracts/gas-snapshots/data-feeds.gas-snapshot

@@ -38,59 +38,60 @@ DataFeedsCacheGasTest:test_write_setDecimalFeedConfigs_with_delete_5_gas() (gas:
 DataFeedsCacheTest:testFuzzy_getDataType(bytes16,uint256) (runs: 256, μ: 9492, ~: 9492)
 DataFeedsCacheTest:testFuzzy_getDataTypeRevertOutOfBound(bytes16,uint256) (runs: 256, μ: 9275, ~: 9275)
 DataFeedsCacheTest:testFuzzy_recoverTokensERC20Success(uint256) (runs: 256, μ: 77137, ~: 77137)
-DataFeedsCacheTest:testFuzzy_recoverTokensNativeSuccess(uint256) (runs: 256, μ: 49076, ~: 49076)
-DataFeedsCacheTest:test_bundleDecimals() (gas: 282615)
-DataFeedsCacheTest:test_decimals() (gas: 221728)
-DataFeedsCacheTest:test_description() (gas: 224377)
+DataFeedsCacheTest:testFuzzy_recoverTokensNativeSuccess(uint256) (runs: 256, μ: 49098, ~: 49098)
+DataFeedsCacheTest:test_bundleDecimals() (gas: 282593)
+DataFeedsCacheTest:test_decimals() (gas: 221706)
+DataFeedsCacheTest:test_description() (gas: 224355)
+DataFeedsCacheTest:test_feedCanBeWrittenToByMultipleWorkflows() (gas: 219534)
 DataFeedsCacheTest:test_getDataIdForProxy() (gas: 15208)
 DataFeedsCacheTest:test_getDataType() (gas: 8885)
-DataFeedsCacheTest:test_getFeedMetadata() (gas: 268430)
-DataFeedsCacheTest:test_getFeedMetadataRevertFeedNotConfigured() (gas: 13396)
-DataFeedsCacheTest:test_getLatestAnswer1() (gas: 307921)
-DataFeedsCacheTest:test_getLatestAnswer2() (gas: 578544)
+DataFeedsCacheTest:test_getFeedMetadata() (gas: 268408)
+DataFeedsCacheTest:test_getFeedMetadataRevertFeedNotConfigured() (gas: 13418)
+DataFeedsCacheTest:test_getLatestAnswer1() (gas: 307899)
+DataFeedsCacheTest:test_getLatestAnswer2() (gas: 578522)
 DataFeedsCacheTest:test_getLatestBundle1() (gas: 410719)
-DataFeedsCacheTest:test_getLatestBundle2() (gas: 781477)
-DataFeedsCacheTest:test_getLatestByFeedId() (gas: 318015)
-DataFeedsCacheTest:test_getWorkflowMetaData() (gas: 10161)
+DataFeedsCacheTest:test_getLatestBundle2() (gas: 781455)
+DataFeedsCacheTest:test_getLatestByFeedId() (gas: 317993)
+DataFeedsCacheTest:test_getWorkflowMetaData() (gas: 10183)
 DataFeedsCacheTest:test_isFeedAdmin() (gas: 14294)
-DataFeedsCacheTest:test_latestAnswer1() (gas: 314086)
-DataFeedsCacheTest:test_latestAnswer2() (gas: 589248)
+DataFeedsCacheTest:test_latestAnswer1() (gas: 314064)
+DataFeedsCacheTest:test_latestAnswer2() (gas: 589203)
 DataFeedsCacheTest:test_latestBundle1() (gas: 420293)
-DataFeedsCacheTest:test_latestBundle2() (gas: 798323)
+DataFeedsCacheTest:test_latestBundle2() (gas: 798301)
 DataFeedsCacheTest:test_onReportInvalidPermission() (gas: 675297)
 DataFeedsCacheTest:test_onReportRevertInvalidWorkflowName() (gas: 252356)
-DataFeedsCacheTest:test_onReportRevertInvalidWorkflowOwner() (gas: 252408)
-DataFeedsCacheTest:test_onReportStaleBundleReport() (gas: 815355)
-DataFeedsCacheTest:test_onReportStaleDecimalReport() (gas: 635704)
+DataFeedsCacheTest:test_onReportRevertInvalidWorkflowOwner() (gas: 252386)
+DataFeedsCacheTest:test_onReportStaleBundleReport() (gas: 815333)
+DataFeedsCacheTest:test_onReportStaleDecimalReport() (gas: 635682)
 DataFeedsCacheTest:test_onReportSuccess_BundleReportLength1() (gas: 402715)
-DataFeedsCacheTest:test_onReportSuccess_BundleReportLength2() (gas: 765928)
-DataFeedsCacheTest:test_onReportSuccess_DecimalReportLength1() (gas: 310107)
-DataFeedsCacheTest:test_onReportSuccess_DecimalReportLength2() (gas: 579872)
-DataFeedsCacheTest:test_onReportSuccess_EmptyBundleReport() (gas: 251217)
+DataFeedsCacheTest:test_onReportSuccess_BundleReportLength2() (gas: 765906)
+DataFeedsCacheTest:test_onReportSuccess_DecimalReportLength1() (gas: 310085)
+DataFeedsCacheTest:test_onReportSuccess_DecimalReportLength2() (gas: 579850)
+DataFeedsCacheTest:test_onReportSuccess_EmptyBundleReport() (gas: 251195)
 DataFeedsCacheTest:test_onReportSuccess_EmptyDecimalReport() (gas: 241310)
-DataFeedsCacheTest:test_onReportSuccess_EmptyReport() (gas: 221809)
+DataFeedsCacheTest:test_onReportSuccess_EmptyReport() (gas: 221787)
 DataFeedsCacheTest:test_recoverTokensERC20RevertNoBalance() (gas: 19972)
 DataFeedsCacheTest:test_recoverTokensNativeRevertNoBalance() (gas: 11489)
 DataFeedsCacheTest:test_recoverTokensRevertUnauthorized() (gas: 13353)
 DataFeedsCacheTest:test_removeDataIdMappingsForProxiesSuccess() (gas: 22198)
 DataFeedsCacheTest:test_removeDataIdMappingsForProxiesSuccess_and_call_decimals() (gas: 24859)
-DataFeedsCacheTest:test_removeFeedAdminSuccess() (gas: 26969)
+DataFeedsCacheTest:test_removeFeedAdminSuccess() (gas: 27005)
 DataFeedsCacheTest:test_removeFeedsRevertInvalidSender() (gas: 12166)
 DataFeedsCacheTest:test_removeFeedsRevertNotConfiguredFeed() (gas: 20111)
-DataFeedsCacheTest:test_removeFeedsSuccess() (gas: 193878)
-DataFeedsCacheTest:test_setBundleFeedConfigsRevertInvalidConfigsLengthDecimals() (gas: 32424)
-DataFeedsCacheTest:test_setBundleFeedConfigs_setAgainWithClear() (gas: 961706)
-DataFeedsCacheTest:test_setDecimalFeedConfigs_setAgainWithClear() (gas: 744404)
+DataFeedsCacheTest:test_removeFeedsSuccess() (gas: 193842)
+DataFeedsCacheTest:test_setBundleFeedConfigsRevertInvalidConfigsLengthDecimals() (gas: 32379)
+DataFeedsCacheTest:test_setBundleFeedConfigs_setAgainWithClear() (gas: 961653)
+DataFeedsCacheTest:test_setDecimalFeedConfigs_setAgainWithClear() (gas: 744352)
 DataFeedsCacheTest:test_setFeedAdminRevertZeroAddress() (gas: 11343)
-DataFeedsCacheTest:test_setFeedConfigsRevertEmptyConfig() (gas: 55665)
-DataFeedsCacheTest:test_setFeedConfigsRevertInvalidConfigsLengthDescriptions() (gas: 48308)
+DataFeedsCacheTest:test_setFeedConfigsRevertEmptyConfig() (gas: 55621)
+DataFeedsCacheTest:test_setFeedConfigsRevertInvalidConfigsLengthDescriptions() (gas: 48286)
 DataFeedsCacheTest:test_setFeedConfigsRevertInvalidWorkflowMetadata() (gas: 94046)
-DataFeedsCacheTest:test_setFeedConfigsRevertUnauthorizedFeedAdmin() (gas: 43091)
-DataFeedsCacheTest:test_setFeedConfigsRevertZeroDataId() (gas: 43243)
-DataFeedsCacheTest:test_setFeedConfigsSuccess() (gas: 220732)
+DataFeedsCacheTest:test_setFeedConfigsRevertUnauthorizedFeedAdmin() (gas: 43047)
+DataFeedsCacheTest:test_setFeedConfigsRevertZeroDataId() (gas: 43199)
+DataFeedsCacheTest:test_setFeedConfigsSuccess() (gas: 220710)
 DataFeedsCacheTest:test_supportsInterface() (gas: 8637)
 DataFeedsCacheTest:test_updateDataIdMappingsForProxiesRevertInvalidLengths() (gas: 12232)
-DataFeedsCacheTest:test_updateDataIdMappingsForProxiesRevertUnauthorizedOwner() (gas: 13207)
+DataFeedsCacheTest:test_updateDataIdMappingsForProxiesRevertUnauthorizedOwner() (gas: 13164)
 DataFeedsCacheTest:test_updateDataIdMappingsForProxiesSuccess() (gas: 21337)
 DataFeedsCacheTest:test_updateDataIdMappingsForProxies_and_RevertOnWrongCaller() (gas: 25810)
 DataFeedsCacheTest:test_updateDataIdMappingsForProxies_and_call_decimals() (gas: 55054)

contracts/src/v0.8/data-feeds/test/DataFeedsCache.t.sol

@@ -1659,6 +1659,26 @@ contract DataFeedsCacheTest is BaseTest {
     string memory description = s_dataFeedsCache.getDescription(dataIds[0]);
     assertEq(description, s_descriptions[0]);
   }
+
+  function test_feedCanBeWrittenToByMultipleWorkflows() public {
+    bytes16[] memory dataIds = new bytes16[](1);
+    dataIds[0] = bytes16(DATAID1);
+    string[] memory _descriptions = new string[](1);
+    _descriptions[0] = s_descriptions[0];
+
+    DataFeedsCache.WorkflowMetadata[] memory workflowMetadata = new DataFeedsCache.WorkflowMetadata[](2);
+    workflowMetadata[0] = s_workflowMetadata1;
+    workflowMetadata[1] = s_workflowMetadata2;
+
+    // Check that multiple Workflows can be permitted to write to a Data ID.
+    s_dataFeedsCache.setDecimalFeedConfigs(dataIds, _descriptions, workflowMetadata);
+
+    bool permitted1 = s_dataFeedsCache.checkFeedPermission(dataIds[0], s_workflowMetadata1);
+    assertEq(permitted1, true);
+
+    bool permitted2 = s_dataFeedsCache.checkFeedPermission(dataIds[0], s_workflowMetadata2);
+    assertEq(permitted2, true);
+  }
 }
 
 contract DataFeedsCacheHarness is DataFeedsCache {