fix: use strings to represent addresses in proposal analyzer (#17397)

This will allow us to use the proposal analyzer types to decode Solana
transactions.

Author: gustavogama-cll

deployment/common/proposalutils/analyze.go

@@ -164,11 +164,11 @@ func (a BytesArgument) Describe(_ *ArgumentContext) string {
 }
 
 type AddressArgument struct {
-	Value common.Address
+	Value string
 }
 
 func (a AddressArgument) Describe(ctx *ArgumentContext) string {
-	description := a.Value.Hex() + " (address of <type unknown> from <chain unknown>)"
+	description := a.Value + " (address of <type unknown> from <chain unknown>)"
 	addresses, err := ContextGet[deployment.AddressesByChain](ctx, "AddressesByChain")
 	if err != nil {
 		return description
@@ -178,9 +178,9 @@ func (a AddressArgument) Describe(ctx *ArgumentContext) string {
 		if err != nil || chainName == "" {
 			chainName = strconv.FormatUint(chainSel, 10)
 		}
-		typeAndVersion, ok := addresses[a.Value.Hex()]
+		typeAndVersion, ok := addresses[a.Value]
 		if ok {
-			return fmt.Sprintf("%s (address of %s from %s)", a.Value.Hex(), typeAndVersion.String(), chainName)
+			return fmt.Sprintf("%s (address of %s from %s)", a.Value, typeAndVersion.String(), chainName)
 		}
 	}
 	return description
@@ -195,7 +195,7 @@ type DecodedCall struct {
 
 func (d *DecodedCall) Describe(context *ArgumentContext) string {
 	description := strings.Builder{}
-	description.WriteString(fmt.Sprintf("Address: %s\n", AddressArgument{Value: common.HexToAddress(d.Address)}.Describe(context)))
+	description.WriteString(fmt.Sprintf("Address: %s\n", AddressArgument{Value: d.Address}.Describe(context)))
 	description.WriteString(fmt.Sprintf("Method: %s\n", d.Method))
 	describedInputs := d.describeArguments(d.Inputs, context)
 	if len(describedInputs) > 0 {
@@ -211,8 +211,11 @@ func (d *DecodedCall) Describe(context *ArgumentContext) string {
 func (d *DecodedCall) describeArguments(arguments []NamedArgument, context *ArgumentContext) string {
 	description := strings.Builder{}
 	for _, argument := range arguments {
-		description.WriteString(argument.Describe(context))
-		description.WriteRune('\n')
+		describedContent := argument.Describe(context)
+		description.WriteString(describedContent)
+		if describedContent[len(describedContent)-1] != '\n' {
+			description.WriteRune('\n')
+		}
 	}
 	return description.String()
 }
@@ -341,11 +344,11 @@ func BytesAndAddressAnalyzer(_ string, argAbi *abi.Type, argVal interface{}, _ [
 	if argAbi.T == abi.FixedBytesTy || argAbi.T == abi.BytesTy || argAbi.T == abi.AddressTy {
 		argArrTyp := reflect.ValueOf(argVal)
 		argArr := make([]byte, argArrTyp.Len())
-		for i := 0; i < argArrTyp.Len(); i++ {
+		for i := range argArrTyp.Len() {
 			argArr[i] = byte(argArrTyp.Index(i).Uint())
 		}
 		if argAbi.T == abi.AddressTy {
-			return AddressArgument{Value: common.BytesToAddress(argArr)}
+			return AddressArgument{Value: common.BytesToAddress(argArr).Hex()}
 		}
 		return BytesArgument{Value: argArr}
 	}