Skip to content

Commit 83dc5cd

Browse files
authored
BCFR-1207 remove UnregisterAll on Close for CR (#17116)
* BCFR-1207 remove UnregisterAll on Close for CR * BCFR-1207 changeset
1 parent 521e772 commit 83dc5cd

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.changeset/tall-dingos-rhyme.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"chainlink": patch
3+
---
4+
5+
#changed filters persist after ChainReader Clean being called

core/services/relay/evm/chain_reader.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import (
88
"maps"
99
"slices"
1010
"strings"
11-
"time"
1211

1312
"github.com/ethereum/go-ethereum/accounts/abi"
1413
"github.com/ethereum/go-ethereum/common"
@@ -172,12 +171,9 @@ func (cr *chainReader) Start(ctx context.Context) error {
172171
})
173172
}
174173

175-
// Close unregisters polling filters for bound contracts.
176174
func (cr *chainReader) Close() error {
177175
return cr.StopOnce("ChainReader", func() error {
178-
ctx, cancel := context.WithTimeout(context.Background(), time.Second)
179-
defer cancel()
180-
return cr.bindings.UnregisterAll(ctx, cr.lp)
176+
return nil
181177
})
182178
}
183179

0 commit comments

Comments
 (0)