-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Open
Description
Description
Some test scripts and helper functions do not consistently handle errors, which can lead to false positives or missed failures. Proper error handling ensures that test failures are detected and reported accurately.
Environment
- Chainlink repo: develop branch
- Go 1.22+
- OS: Linux 6.11.0-29-generic
Examples
integration-tests/actions/some_action.go
: Error values are ignored in some helper functions.core/internal/cltest/cltest.go
: Some test helpers do not check returned errors.
Steps to Reproduce
- Review test helper functions for unchecked errors.
- Run tests and introduce intentional errors to verify detection.
Additional Info
- Use
require.NoError
orassert.NoError
for error checks in tests. - Consider enabling
go vet
or static analysis for error handling.
Metadata
Metadata
Assignees
Labels
No labels