Remove redundant isDot() check and fix static analysis warnings

Author: h-marumoto

src/Cacheresource/File.php

@@ -221,10 +221,8 @@ public function clear(Smarty $smarty, $resource_name, $cache_id, $compile_id, $e
 			    $_filepath = (string)$_file;
 			    // directory ?
 			    if ($_file->isDir()) {
-				    if (!$_file->isDot()) {
-					    // delete folder if empty
-					    @rmdir($_file->getPathname());
-				    }
+                    // delete folder if empty
+                    @rmdir($_file->getPathname());
 			    } else {
 				    // delete only php files
 				    if (substr($_filepath, -4) !== '.php') {

src/Smarty.php

@@ -1344,10 +1344,8 @@ public function clearCompiledTemplate($resource_name = null, $compile_id = null,
 			}
 			$_filepath = (string)$_file;
 			if ($_file->isDir()) {
-				if (!$_file->isDot()) {
-					// delete folder if empty
-					@rmdir($_file->getPathname());
-				}
+				// delete folder if empty
+				@rmdir($_file->getPathname());
 			} else {
 				// delete only php files
 				if (substr($_filepath, -4) !== '.php') {

tests/PHPUnit_Smarty.php

@@ -291,10 +291,8 @@ public function cleanDir($dir)
             }
             // directory ?
             if ($file->isDir()) {
-                if (!$file->isDot()) {
-                    // delete folder if empty
-                    @rmdir($file->getPathname());
-                }
+                // delete folder if empty
+                @rmdir($file->getPathname());
             } else {
                 unlink($file->getPathname());
             }