Skip to content

Commit 57e65cd

Browse files
committed
update test to match firefox 124 behavior, set node to 21 to ci
1 parent 40211f5 commit 57e65cd

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

.github/workflows/chrome-tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- uses: actions/checkout@v3
1212
- uses: actions/setup-node@v3
1313
with:
14-
node-version: 20
14+
node-version: 21
1515
- uses: pnpm/action-setup@v2
1616
name: Install pnpm
1717
with:

.github/workflows/firefox-tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- uses: actions/checkout@v3
1212
- uses: actions/setup-node@v3
1313
with:
14-
node-version: 20
14+
node-version: 21
1515
- uses: pnpm/action-setup@v2
1616
name: Install pnpm
1717
with:

.github/workflows/publish.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- uses: actions/checkout@v3
2121
- uses: actions/setup-node@v3
2222
with:
23-
node-version: '20.x'
23+
node-version: '21.x'
2424
registry-url: 'https://registry.npmjs.org'
2525
- uses: pnpm/action-setup@v2
2626
name: Install pnpm

packages/vue-collapsed/tests/Collapse.cy.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -275,10 +275,14 @@ describe('With baseHeight > 0', () => {
275275

276276
cy.get('#TriggerButton').click()
277277

278+
const transition = 'height 0.3s cubic-bezier(0.33, 1, 0.68, 1)'
279+
278280
cy.get('#Collapse').should(
279281
'have.css',
280282
'transition',
281-
'height 0.3s cubic-bezier(0.33, 1, 0.68, 1) 0s'
283+
isFirefox
284+
? transition // Firefox >= 124 doesn't include '0s' by default anymore
285+
: `${transition} 0s`
282286
)
283287

284288
cy.get('#Collapse').and('have.attr', 'style').and('include', '--vc-auto-duration: 300ms')

0 commit comments

Comments
 (0)