Merge pull request #659 from smile-io/drop-invoke-action-dep

Drop ember-invoke-action dependency

Author: vladucu

addon/components/polaris-action-list/section.js

@@ -1,6 +1,5 @@
 import Component from '@ember/component';
 import { action, computed } from '@ember/object';
-import { invokeAction } from 'ember-invoke-action';
 import { tagName, layout } from '@ember-decorators/component';
 import template from '../../templates/components/polaris-action-list/section';
 
@@ -40,11 +39,11 @@ export default class PolarisActionListSection extends Component {
   }
 
   @action
-  onItemAction(item, event) {
+  handleAction(item, event) {
     event.preventDefault();
     event.stopPropagation();
 
-    invokeAction(item, 'onAction');
-    invokeAction(this, 'onActionAnyItem');
+    item.onAction?.();
+    this.onActionAnyItem?.();
   }
 }

addon/components/polaris-banner.js

@@ -6,7 +6,6 @@ import { guidFor } from '@ember/object/internals';
 import { capitalize } from '@ember/string';
 import { deprecate } from '@ember/application/deprecations';
 import { tagName, layout } from '@ember-decorators/component';
-import { invokeAction } from 'ember-invoke-action';
 import template from '../templates/components/polaris-banner';
 import { handleMouseUpByBlurring } from '../utils/focus';
 import deprecateClassArgument from '../utils/deprecate-class-argument';
@@ -210,7 +209,7 @@ export default class PolarisBanner extends Component {
       event.stopPropagation();
     }
 
-    return invokeAction(this, actionObj.onAction);
+    return this.actionObj?.onAction();
   }
 
   @action

addon/components/polaris-page-actions.js

@@ -1,8 +1,7 @@
 import Component from '@ember/component';
-import { action, computed } from '@ember/object';
+import { computed } from '@ember/object';
 import { isArray } from '@ember/array';
 import { tagName, layout as templateLayout } from '@ember-decorators/component';
-import { invokeAction } from 'ember-invoke-action';
 import layout from '../templates/components/polaris-page-actions';
 import deprecateClassArgument from '../utils/deprecate-class-argument';
 
@@ -36,9 +35,4 @@ export default class PolarisPageActions extends Component {
   get showSecondaryActions() {
     return isArray(this.secondaryActions);
   }
-
-  @action
-  fireAction(act) {
-    invokeAction(act, 'onAction');
-  }
 }

addon/components/polaris-setting-toggle.js

@@ -1,9 +1,7 @@
 import Component from '@ember/component';
-import { action } from '@ember/object';
 import { or } from '@ember/object/computed';
 import { deprecate } from '@ember/application/deprecations';
 import { tagName, layout as templateLayout } from '@ember-decorators/component';
-import { invokeAction } from 'ember-invoke-action';
 import layout from '../templates/components/polaris-setting-toggle';
 
 /**
@@ -58,9 +56,4 @@ export default class PolarisSettingToggle extends Component {
       }
     );
   }
-
-  @action
-  fireAction(primaryAction) {
-    invokeAction(primaryAction, 'onAction');
-  }
 }

addon/templates/components/polaris-action-list/section.hbs

@@ -26,7 +26,7 @@
             @active={{item.active}}
             @role={{@actionRole}}
             @badge={{item.badge}}
-            @onAction={{fn this.onItemAction item}}
+            @onAction={{fn this.handleAction item}}
           />
         {{/each}}
       </ul>

addon/templates/components/polaris-page-actions.hbs

@@ -12,7 +12,7 @@
             @loading={{secondaryAction.loading}}
             @destructive={{secondaryAction.destructive}}
             @icon={{secondaryAction.icon}}
-            @onClick={{fn this.fireAction secondaryAction}}
+            @onClick={{secondaryAction.onAction}}
           />
         {{/each}}
       </PolarisButtonGroup>
@@ -24,7 +24,7 @@
         @disabled={{@primaryAction.disabled}}
         @loading={{@primaryAction.loading}}
         @text={{@primaryAction.text}}
-        @onClick={{fn this.fireAction @primaryAction}}
+        @onClick={{@primaryAction.onAction}}
       />
     {{/if}}
   </PolarisStack>

addon/templates/components/polaris-setting-toggle.hbs

@@ -15,7 +15,7 @@
           @disabled={{this.mainAction.disabled}}
           @loading={{this.mainAction.loading}}
           @primary={{@enabled}}
-          @onClick={{fn this.fireAction this.mainAction}}
+          @onClick={{this.mainAction.onAction}}
         />
       {{/if}}
     </div>

addon/utils/map-event-to-action.js

@@ -65,7 +65,6 @@
     "ember-decorators": "^6.1.1",
     "ember-element-helper": "^0.3.1",
     "ember-event-helpers": "^0.1.0",
-    "ember-invoke-action": "^1.5.1",
     "ember-keyboard": "^6.0.1",
     "ember-lifeline": "^4.1.5",
     "ember-render-detector": "^1.0.0",

package.json

@@ -6644,13 +6644,6 @@ [email protected]:
   resolved "https://registry.yarnpkg.com/ember-export-application-global/-/ember-export-application-global-2.0.1.tgz#b120a70e322ab208defc9e2daebe8d0dfc2dcd46"
   integrity sha512-B7wiurPgsxsSGzJuPFkpBWnaeuCu2PGpG2BjyrfA1VcL7//o+5RSnZqiCEY326y7qmxb2GoCgo0ft03KBU0rRw==
 
-ember-invoke-action@^1.5.1:
-  version "1.5.1"
-  resolved "https://registry.yarnpkg.com/ember-invoke-action/-/ember-invoke-action-1.5.1.tgz#b6cad51ee729fc227cdbdba83b2b5486f0fa5834"
-  integrity sha512-co6Yg9r5qtK4LvZTZHk+u02YLPbnM2c5ZkXvundxEj3V7qdZg7RULfjU09LmohD+rxW5ADZlwgBi/32XIEWTlw==
-  dependencies:
-    ember-cli-babel "^6.6.0"
-
 ember-keyboard@^6.0.1:
   version "6.0.1"
   resolved "https://registry.yarnpkg.com/ember-keyboard/-/ember-keyboard-6.0.1.tgz#2e806c92f36ec9a8a85064ca246e23eb11245dae"