Skip to content

Commit 861f340

Browse files
authored
Update minicbor to 2.2.1 (#4653)
## Motivation and Context Upgrades `minicbor` from 0.24.2 to 2.2.1 ## Description After upgrading `minicbor` from 0.24.2 to 2.2.1 in `aws-smithy-cbor`, two CI checks broke: 1. `cargo-deny` license check: The existing exception for `minicbor`'s `BlueOak-1.0.0` license was pinned to `version = "<=0.24.2"`, which didn't cover the new 2.2.1 version. Updated the version constraint to `<=2.2.1`. 2. `sdk-lockfiles` audit: The published `aws-smithy-http-server` 0.65.10 (pulled in as an optional backward-compat dependency by `aws-smithy-http-server-metrics`) still depends on the old `aws-smithy-cbor` 0.61.5, which transitively pulls in `minicbor-derive` 0.15.3 via `minicbor` 0.24.4. Since `minicbor-derive` isn't needed by the SDK, temporarily added it to `false-positives.txt`. ## Testing - CI - No statistically significant regression observed in standard serde benchmarks (n=10000, x86_64, AL2023) | Benchmark ID | Mean ns (main) | Mean ns (PR) | Δ% | |---|---|---|---| | rpcv2Cbor_PutItemRequest_Baseline | 1,749 | 1,863 | +6.5% | | rpcv2Cbor_PutItemRequest_BinaryData_S | 1,795 | 1,819 | +1.3% | | rpcv2Cbor_PutItemRequest_BinaryData_M | 2,563 | 2,557 | -0.2% | | rpcv2Cbor_PutItemRequest_BinaryData_L | 7,240 | 7,319 | +1.1% | | rpcv2Cbor_PutItemRequest_MixedItem_S | 2,370 | 2,311 | -2.5% | | rpcv2Cbor_PutItemRequest_MixedItem_M | 5,846 | 5,921 | +1.3% | | rpcv2Cbor_PutItemRequest_MixedItem_L | 14,294 | 14,598 | +2.1% | | rpcv2Cbor_PutItemRequest_Nested_M | 2,124 | 1,993 | -6.2% | | rpcv2Cbor_PutItemRequest_Nested_L | 3,220 | 3,270 | +1.6% | | rpcv2Cbor_PutItemRequest_ShallowMap_S | 2,402 | 2,471 | +2.9% | | rpcv2Cbor_PutItemRequest_ShallowMap_M | 6,658 | 6,480 | -2.7% | | rpcv2Cbor_PutItemRequest_ShallowMap_L | 19,163 | 18,898 | -1.4% | ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
1 parent 06a18f2 commit 861f340

8 files changed

Lines changed: 242 additions & 199 deletions

File tree

.cargo-deny-config.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ exceptions = [
2222
{ allow = ["OpenSSL"], name = "ring", version = "*" },
2323
{ allow = ["OpenSSL"], name = "aws-lc-sys", version = "*" },
2424
{ allow = ["OpenSSL"], name = "aws-lc-fips-sys", version = "*" },
25-
{ allow = ["BlueOak-1.0.0"], name = "minicbor", version = "<=0.24.2" },
25+
{ allow = ["BlueOak-1.0.0"], name = "minicbor", version = "<=2.2.1" },
2626
# Safe to bump as long as license does not change -------------^
2727
# See D105255799.
2828
]

aws/rust-runtime/Cargo.lock

Lines changed: 40 additions & 37 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)