Use set

Author: richardwang1124

gems/smithy-client/lib/smithy-client/features.rb

@@ -6,15 +6,15 @@ module Client
     module Features
       class << self
         def track(*features, &block)
-          Thread.current[:smithy_ruby_features] ||= []
-          Thread.current[:smithy_ruby_features].concat(features)
+          Thread.current[:smithy_ruby_features] ||= Set.new
+          added = features.map { |f| Thread.current[:smithy_ruby_features].add?(f) }
           block.call
         ensure
-          Thread.current[:smithy_ruby_features].pop(features.size)
+          features.each_with_index { |f, i| Thread.current[:smithy_ruby_features].delete(f) if added[i] }
         end
 
         def tracked
-          Thread.current[:smithy_ruby_features] || []
+          Thread.current[:smithy_ruby_features] || Set.new
         end
       end
     end

gems/smithy-client/spec/smithy-client/features_spec.rb

@@ -6,35 +6,35 @@ module Smithy
   module Client
     describe Features do
       it 'tracks and removes a feature' do
-        Features.track('A') { expect(Features.tracked).to eq(%w[A]) }
+        Features.track('A') { expect(Features.tracked).to eq(%w[A].to_set) }
         expect(Features.tracked).to be_empty
       end
 
       it 'tracks and removes multiple features' do
-        features = %w[A B C]
+        features = %w[A B C].to_set
         Features.track(*features) { expect(Features.tracked).to eq(features) }
         expect(Features.tracked).to be_empty
       end
 
       it 'tracks and removes features in stack order' do
         Features.track('A') do
-          expect(Features.tracked).to eq(%w[A])
+          expect(Features.tracked).to eq(%w[A].to_set)
           Features.track('B') do
-            expect(Features.tracked).to eq(%w[A B])
+            expect(Features.tracked).to eq(%w[A B].to_set)
             Features.track('C') do
-              expect(Features.tracked).to eq(%w[A B C])
+              expect(Features.tracked).to eq(%w[A B C].to_set)
             end
-            expect(Features.tracked).to eq(%w[A B])
+            expect(Features.tracked).to eq(%w[A B].to_set)
           end
-          expect(Features.tracked).to eq(%w[A])
+          expect(Features.tracked).to eq(%w[A].to_set)
         end
         expect(Features.tracked).to be_empty
       end
 
       it 'ensures that features are removed' do
         begin
           Features.track('A') do
-            expect(Features.tracked).to eq(%w[A])
+            expect(Features.tracked).to eq(%w[A].to_set)
             raise StandardError
           end
         rescue StandardError
@@ -45,15 +45,30 @@ module Client
 
       it 'tracks features in multiple threads' do
         Features.track('A') do
-          expect(Features.tracked).to eq(%w[A])
+          expect(Features.tracked).to eq(%w[A].to_set)
           Thread.new do
             expect(Features.tracked).to be_empty
             Features.track('B') do
-              expect(Features.tracked).to eq(%w[B])
+              expect(Features.tracked).to eq(%w[B].to_set)
             end
             expect(Features.tracked).to be_empty
           end.join
-          expect(Features.tracked).to eq(%w[A])
+          expect(Features.tracked).to eq(%w[A].to_set)
+        end
+        expect(Features.tracked).to be_empty
+      end
+
+      it 'does not track duplicate features' do
+        Features.track('A') do
+          expect(Features.tracked).to eq(%w[A].to_set)
+          Features.track('B') do
+            expect(Features.tracked).to eq(%w[A B].to_set)
+            Features.track('A') do
+              expect(Features.tracked).to eq(%w[A B].to_set)
+            end
+            expect(Features.tracked).to eq(%w[A B].to_set)
+          end
+          expect(Features.tracked).to eq(%w[A].to_set)
         end
         expect(Features.tracked).to be_empty
       end

projections/shapes/lib/shapes/client.rb

@@ -161,8 +161,7 @@ class Client < Smithy::Client::Base
     # @option options [Boolean] :stub_responses
     #  When `true`, the client will return stubbed responses instead of networking requests.
     #  By default fake responses are generated and returned. You can specify the response data
-    #  to return or errors to raise by calling {Stubs#stub_responses}.
-    #  @see Stubs
+    #  to return or errors to raise by calling {Smithy::Client::Stubs#stub_responses}.
     # @option options [String] :user_agent_suffix
     #  An optional string that is appended to the User-Agent header.
     #  The default User-Agent includes the smithy-client version,

projections/weather/lib/weather/client.rb

@@ -161,8 +161,7 @@ class Client < Smithy::Client::Base
     # @option options [Boolean] :stub_responses
     #  When `true`, the client will return stubbed responses instead of networking requests.
     #  By default fake responses are generated and returned. You can specify the response data
-    #  to return or errors to raise by calling {Stubs#stub_responses}.
-    #  @see Stubs
+    #  to return or errors to raise by calling {Smithy::Client::Stubs#stub_responses}.
     # @option options [String] :user_agent_suffix
     #  An optional string that is appended to the User-Agent header.
     #  The default User-Agent includes the smithy-client version,