Minor formatting of specs

Author: Matt Muller

gems/smithy-client/spec/smithy-client/plugins/checksum_required_spec.rb

@@ -10,7 +10,20 @@ module Plugins
       describe ChecksumRequired do
         let(:shapes) { ClientHelper.sample_shapes }
         let(:sample_client) { ClientHelper.sample_client(shapes: shapes) }
-        let(:client_class) { sample_client.const_get(:Client) }
+
+        let(:client_class) do
+          client_class = sample_client.const_get(:Client)
+          client_class.clear_plugins
+          client_class.add_plugin(sample_client::Plugins::Auth)
+          client_class.add_plugin(sample_client::Plugins::Endpoint)
+          client_class.add_plugin(AnonymousAuth)
+          client_class.add_plugin(ChecksumRequired)
+          client_class.add_plugin(Protocol)
+          client_class.add_plugin(SignRequests)
+          client_class.add_plugin(StubResponses)
+          client_class
+        end
+
         let(:client) { client_class.new(stub_responses: true) }
 
         before do

gems/smithy-client/spec/smithy-client/plugins/host_prefix_spec.rb

@@ -10,7 +10,17 @@ module Plugins
       describe HostPrefix do
         let(:shapes) { ClientHelper.sample_shapes }
         let(:sample_client) { ClientHelper.sample_client(shapes: shapes) }
-        let(:client_class) { sample_client.const_get(:Client) }
+
+        let(:client_class) do
+          client_class = sample_client.const_get(:Client)
+          client_class.clear_plugins
+          client_class.add_plugin(sample_client::Plugins::Endpoint)
+          client_class.add_plugin(HostPrefix)
+          client_class.add_plugin(Protocol)
+          client_class.add_plugin(StubResponses)
+          client_class
+        end
+
         let(:client) { client_class.new(stub_responses: true) }
 
         it 'adds a :disable_host_prefix_injection option to config' do
@@ -39,7 +49,7 @@ module Plugins
           expect(client.config.disable_host_prefix_injection).to be(true)
         end
 
-        context 'handler' do
+        context 'host prefixing' do
           before do
             shapes['smithy.ruby.tests#Structure']['members']['string'] = {
               'target' => 'smithy.api#String',

gems/smithy-client/spec/smithy-client/plugins/idempotency_token_spec.rb

@@ -10,7 +10,17 @@ module Plugins
       describe IdempotencyToken do
         let(:shapes) { ClientHelper.sample_shapes }
         let(:sample_client) { ClientHelper.sample_client(shapes: shapes) }
-        let(:client_class) { sample_client.const_get(:Client) }
+
+        let(:client_class) do
+          client_class = sample_client.const_get(:Client)
+          client_class.clear_plugins
+          client_class.add_plugin(sample_client::Plugins::Endpoint)
+          client_class.add_plugin(IdempotencyToken)
+          client_class.add_plugin(Protocol)
+          client_class.add_plugin(StubResponses)
+          client_class
+        end
+
         let(:client) { client_class.new(stub_responses: true) }
 
         before do

gems/smithy-client/spec/smithy-client/plugins/net_http_spec.rb

@@ -16,27 +16,26 @@ module Plugins
         end
 
         it 'adds net http options' do
-          options = {
-            # Connections
-            http_continue_timeout: 1,
-            http_keep_alive_timeout: 1,
-            http_open_timeout: 1,
-            http_read_timeout: 1,
-            http_ssl_timeout: 1,
-            http_write_timeout: 1,
-            # Security
-            http_ca_file: 'file',
-            http_ca_path: 'path/to/files',
-            http_cert: 'cert',
-            http_cert_store: 'store',
-            http_key: 'key',
-            http_verify_mode: OpenSSL::SSL::VERIFY_NONE,
-            # Debugging
-            http_debug_output: true,
-            # Proxies
-            http_proxy: 'http://proxy.com:123'
-          }
-          client_class.new(options)
+          options = %i[
+            http_continue_timeout
+            http_keep_alive_timeout
+            http_open_timeout
+            http_read_timeout
+            http_ssl_timeout
+            http_write_timeout
+            http_ca_file
+            http_ca_path
+            http_cert
+            http_cert_store
+            http_key
+            http_verify_mode
+            http_debug_output
+            http_proxy
+          ]
+          client = client_class.new
+          options.each do |option|
+            expect(client.config).to respond_to(option)
+          end
         end
       end
     end

gems/smithy-client/spec/smithy-client/plugins/request_compression_spec.rb

@@ -10,7 +10,17 @@ module Plugins
       describe RequestCompression do
         let(:shapes) { ClientHelper.sample_shapes }
         let(:sample_client) { ClientHelper.sample_client(shapes: shapes) }
-        let(:client_class) { sample_client.const_get(:Client) }
+
+        let(:client_class) do
+          client_class = sample_client.const_get(:Client)
+          client_class.clear_plugins
+          client_class.add_plugin(sample_client::Plugins::Endpoint)
+          client_class.add_plugin(RequestCompression)
+          client_class.add_plugin(Protocol)
+          client_class.add_plugin(StubResponses)
+          client_class
+        end
+
         let(:client) { client_class.new(stub_responses: true) }
 
         it 'adds a :disable_request_compression option to config' do

gems/smithy-client/spec/spec_helper.rb

@@ -14,7 +14,6 @@
 
 require_relative 'support/client_helper'
 
-# TODO: remove this?
 class DummySendPlugin < Smithy::Client::Plugin
   class Handler < Smithy::Client::Handler
     def call(context)