Skip to content

Commit 269b2b5

Browse files
committed
Remove scratches
1 parent 3a4c0d1 commit 269b2b5

2 files changed

Lines changed: 0 additions & 4 deletions

File tree

gems/smithy-schema/lib/smithy-schema/document.rb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ def set_data(data, options)
6666
else
6767
if discriminator?(data)
6868
# case 2 - extract typed data from parsed JSON
69-
# Open question - if there is a schema given, should we validate that these
70-
# two pieces work together?
7169
data.except('__type')
7270
else
7371
# case 3 - untyped data, we will need consolidate timestamps and such
@@ -76,7 +74,6 @@ def set_data(data, options)
7674
end
7775
end
7876

79-
# TODO: probably need to check if given runtime shape is a type of schema
8077
def valid_schema?(schema)
8178
schema.is_a?(Shapes::StructureShape) && !schema.type.nil?
8279
end

gems/smithy-schema/spec/spec_helper.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
SimpleCov.start
55

66
require 'smithy-schema'
7-
require_relative 'support/schema_helper'
87

98
# This file was generated by the `rspec --init` command. Conventionally, all
109
# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.

0 commit comments

Comments
 (0)